pg.ddx.io pgsql-bugs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
BUG #16248: ALTER SYSTEM quoting of values does not work as expected 2+ messages / 2 participants [nested] [flat]
* BUG #16248: ALTER SYSTEM quoting of values does not work as expected @ 2020-02-07 18:20 PG Bug reporting form <noreply@postgresql.org> 0 siblings, 1 reply; 2+ messages in thread From: PG Bug reporting form @ 2020-02-07 18:20 UTC (permalink / raw) To: pgsql-bugs@lists.postgresql.org; +Cc: gabrielle@pdx.postgresql.us The following bug has been logged on the website: Bug reference: 16248 Logged by: gabrielle roth Email address: gabrielle@pdx.postgresql.us PostgreSQL version: 11.6 Operating system: Ubuntu Description: Hi all! I tried out `ALTER SYSTEM` for the first time last week, and ran into something that confused me: tl;dr: ALTER SYSTEM SET log_statement = 'all'; -- quotes required around the new value vs ALTER SYSTEM SET shared_preload_libraries = pg_stat_statements,plprofiler; -- requires the new value *not* be quoted, this is what's confusing me How I got there: Initially, I tried quotes around the value, as that's the way I'd write it in postgresql.conf: ALTER SYSTEM SET shared_preload_libraries = 'pg_stat_statements,plprofiler'; When I restarted my database to apply the change, it failed with this error (note the value now has double quotes) FATAL: could not access file "pg_stat_statements,plprofiler": No such file or directory And this is what ended up in postgresql.auto.conf: shared_preload_libraries = '"pg_stat_statements,plprofiler"' From the docs for ALTER SYSTEM (https://www.postgresql.org/docs/11/sql-altersystem.html): "Values can be specified as string constants, identifiers, numbers, or comma-separated lists of these, as appropriate for the particular parameter." From the docs for "Setting parameters" (https://www.postgresql.org/docs/11/config-setting.html): "String: In general, enclose the value in single quotes, doubling any single quotes within the value. Quotes can usually be omitted if the value is a simple number or identifier, however." I eventually got help from a friend, who tipped me off that the value for shared_preload_libraries should not be quoted. That seems weird to me because of the requirement for quoting on other settings, e.g. log_statement. Is this expected behavior? If so, can we get some examples in the docs to help folks figure out the correct quoting rules? Thank you! gabrielle ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: BUG #16248: ALTER SYSTEM quoting of values does not work as expected @ 2020-02-07 19:12 Tom Lane <tgl@sss.pgh.pa.us> parent: PG Bug reporting form <noreply@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-02-07 19:12 UTC (permalink / raw) To: gabrielle@pdx.postgresql.us; +Cc: pgsql-bugs@lists.postgresql.org PG Bug reporting form <noreply@postgresql.org> writes: > tl;dr: > ALTER SYSTEM SET log_statement = 'all'; -- quotes required around the new > value The reason for that is that ALL is a reserved word in SQL. > ALTER SYSTEM SET shared_preload_libraries = pg_stat_statements,plprofiler; > -- requires the new value *not* be quoted, this is what's confusing me Well, you could quote the list elements individually, eg ALTER SYSTEM SET shared_preload_libraries = 'pg_stat_statements','plprofiler'; But this: > ALTER SYSTEM SET shared_preload_libraries = > 'pg_stat_statements,plprofiler'; says you just want one list element that happens to include a comma. No, the syntax rules here are not the same as they are in postgresql.conf. > Is this expected behavior? If so, can we get some examples in the docs to > help folks figure out the correct quoting rules? AFAICS the documentation statements you quoted are accurate. regards, tom lane ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-02-07 19:12 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-02-07 18:20 BUG #16248: ALTER SYSTEM quoting of values does not work as expected PG Bug reporting form <noreply@postgresql.org> 2020-02-07 19:12 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox