Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hepKV-000287-71
	for pgsql-bugs@arkaria.postgresql.org; Sat, 22 Jun 2019 23:21:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hepKS-0003oL-SF
	for pgsql-bugs@arkaria.postgresql.org; Sat, 22 Jun 2019 23:21:52 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hepKS-0003oE-Ke
	for pgsql-bugs@lists.postgresql.org; Sat, 22 Jun 2019 23:21:52 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hepKO-0005ma-Tu
	for pgsql-bugs@lists.postgresql.org; Sat, 22 Jun 2019 23:21:50 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x5MNLeKv029167;
	Sat, 22 Jun 2019 19:21:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: YunQiang Su <wzssyqa@gmail.com>
cc: Andres Freund <andres@anarazel.de>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
In-reply-to: 
 <CAKcpw6UtS-y7ZRBm+9FAsL8NXeBhhBpqdK47ifYbYFvoq2g7cg@mail.gmail.com>
References: <15844-8f62fe7e163939b3@postgresql.org>
 <15052.1560455595@sss.pgh.pa.us>
 <CAKcpw6W2WBdTVnJSeV845V78bwOPDjhROfteX7D2o0TTU2_opA@mail.gmail.com>
 <23287.1560655935@sss.pgh.pa.us>
 <CAKcpw6W8Y56cxKJna6EsA+j2ZQ1p6DeXwMJFOOjb=baPigbV+Q@mail.gmail.com>
 <25321.1560659282@sss.pgh.pa.us>
 <CAKcpw6XYkD9Ku-0Fw6VZ6=wR030c5xCBOnTGsjLzFqdffkM8dw@mail.gmail.com>
 <22615.1560701813@sss.pgh.pa.us>
 <20190617163207.kgi5m4v2g2m252t5@alap3.anarazel.de>
 <8749.1560790222@sss.pgh.pa.us>
 <CAKcpw6VZVerXTHWSxp341GeogHQBOY9p5w3VRwGMXcxcr_hhtw@mail.gmail.com>
 <19682.1561230332@sss.pgh.pa.us> <27494.1561243027@sss.pgh.pa.us>
 <CAKcpw6UtS-y7ZRBm+9FAsL8NXeBhhBpqdK47ifYbYFvoq2g7cg@mail.gmail.com>
Comments: In-reply-to YunQiang Su <wzssyqa@gmail.com>
	message dated "Sun, 23 Jun 2019 06:59:44 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <29165.1561245700.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sat, 22 Jun 2019 19:21:40 -0400
Message-ID: <29166.1561245700@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

YunQiang Su <wzssyqa@gmail.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> 于2019年6月23日周日 上午6:37写道：
>> So I now think your original proposal was about the best way to do this,
>> though I'd tweak it to make the test be "#if __mips_isa_rev < 2", as

> here we should use #if __mips < 2 instead of __mips_isa_rev .

OK, will do.

			regards, tom lane