From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: paul.vanderlinden@mapcreator.eu,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: BUG #15460: Error while creating index or constraint
In-reply-to: 
 <CAH2-WzmS+eYnDuULw5M=cFsxJ6xxKkaysdLbh2mO26Wb_7wZBg@mail.gmail.com>
References: <15460-b6db80de822fa0ad@postgresql.org>
 <CAH2-Wzk=pj9SN+=HZCYwAc3WHe+_SErqA3xoLxj2y_GwSQ+Dag@mail.gmail.com>
 <26974.1540826748@sss.pgh.pa.us>
 <CAH2-WzmS+eYnDuULw5M=cFsxJ6xxKkaysdLbh2mO26Wb_7wZBg@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Mon, 29 Oct 2018 15:44:15 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29351.1540830505.1@sss.pgh.pa.us>
Date: Mon, 29 Oct 2018 12:28:25 -0400
Message-ID: <29352.1540830505@sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Oct 29, 2018 at 3:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Sounds like papering over the bug ...

> I may have been unclear. It would be papering over the bug if I went
> ahead and did that now.

> The advantage of getting the file size from shared memory is that it
> doesn't leave it up to code like BufFileOpenShared() to find
> everything through readdir() iteration, an approach that might not be
> totally portable. We'll reliably fail if all BufFile segments cannot
> be accounted for with the size-in-shared-memory approach, which seems
> more robust. I wouldn't be surprised if that actually was the correct
> fix in the end.

Perhaps.  Anyway, I think we agree that we should identify why it's
failing before we decide on a fix.

			regards, tom lane