From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: David Rowley <dgrowleyml@gmail.com>, justin@tonic.ai,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17753: pg_dump --if-exists bug
In-reply-to: <282372.1674166935@sss.pgh.pa.us>
References: <17753-9c8773631747ee1c@postgresql.org>
 <CAApHDvq+JTtZWOrXBrY7LvquyXHoCWWq=DfPYKB4b7BuFiM_8A@mail.gmail.com>
 <4062761.1674142680@sss.pgh.pa.us> <282372.1674166935@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 19 Jan 2023 17:22:15 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <294748.1674173390.1@sss.pgh.pa.us>
Date: Thu, 19 Jan 2023 19:09:50 -0500
Message-ID: <294749.1674173390@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/294749.1674173390%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I think we need to do the attached, more or less.  Also, although the
> given case seems to be new, we'd probably better back-patch, because
> I'm not convinced that there aren't other ways to reach this.

Ah --- we only need to back-patch to v15, because this business of
possibly having a comment in the dropStmt is new in a7a7be1f2.
That commit also added the existing exceptions for comments in
pg_backup_archiver.c ... but it missed the need to have special
cases for dropStmts too.

			regards, tom lane