From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
cc: Japin Li <japinli@hotmail.com>,
        =?UTF-8?Q?L=C3=A6titia_Avrot?= <laetitia.avrot@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: Statistics updates is delayed when using `commit and chain`
In-reply-to: 
 <CAFBsxsGbUgeGke_xEWfrnWqoL2U1LDCA2O5bMRr-0m8UxPqyxA@mail.gmail.com>
References: 
 <CAB_COditjdhpZ4j=mZ3YG-uG=bqNtXWcBSAkwEJu3cX1X5myOA@mail.gmail.com>
 <MEYP282MB166920830D2969428D7028EBB6189@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <MEYP282MB1669EDFA7400DF3671400D27B6189@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAFBsxsHPm+CvjKGM+Whmxx0UWTCk8-meU44YcB9ya2xbw1+0Kw@mail.gmail.com>
 <MEYP282MB16691D91C25CB36079C9AC19B6179@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAB_COdjsWH+tjJHa4=FyUeSs+nCGegofiJwFmKzX+=xsGsP_Bw@mail.gmail.com>
 <MEYP282MB1669494707E6A49C2AC763FEB6159@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAFBsxsGbUgeGke_xEWfrnWqoL2U1LDCA2O5bMRr-0m8UxPqyxA@mail.gmail.com>
Comments: In-reply-to John Naylor <john.naylor@enterprisedb.com>
	message dated "Mon, 12 Jul 2021 10:08:42 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2950680.1626103840.1@sss.pgh.pa.us>
Date: Mon, 12 Jul 2021 11:30:40 -0400
Message-ID: <2950681.1626103840@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2950681.1626103840%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@enterprisedb.com> writes:
> I understand this functionality to be tracking what happens at the physical
> level, in which case it is correct. In any case, the bug reported is clear
> and changing that behavior is the focus here. About the patch:

I do not think this is a bug at all.  The behavior is, and always has
been, that we report stats when we are about to wait for client input
and are not inside a transaction.  Likewise for NOTIFY.  The proposed
patch randomly changes that in a way that is very likely to break
clients.

Maybe you can persuade me that there's a reason to move the responsibility
for stats reporting to some other place, but please keep your hands
OFF of NOTIFY.  You clearly haven't the faintest idea what the client
contract for that is.

			regards, tom lane