From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Delaney, Ed" <Ed.Delaney@ellucian.com>
cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: Postgres 13.5 out parameter argument with explicit cast fails
 with argument is not writable
In-reply-to: 
 <DM8PR02MB79575CE6CE819DB8C424CCABF1339@DM8PR02MB7957.namprd02.prod.outlook.com>
References: 
 <DM8PR02MB79575CE6CE819DB8C424CCABF1339@DM8PR02MB7957.namprd02.prod.outlook.com>
Comments: In-reply-to "Delaney, Ed" <Ed.Delaney@ellucian.com>
	message dated "Mon, 14 Feb 2022 22:50:06 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2959721.1644881309.1@sss.pgh.pa.us>
Date: Mon, 14 Feb 2022 18:28:29 -0500
Message-ID: <2959722.1644881309@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2959722.1644881309%40sss.pgh.pa.us>
Precedence: bulk

"Delaney, Ed" <Ed.Delaney@ellucian.com> writes:
> create or replace procedure bar ()
> language plpgsql
> as $procedure$
> declare
>   lv_somestring character varying (4000);
> begin
>    call foo(lv_somestring::character varying);  -- note cast
>    raise notice 'lv_somestring: %', lv_somestring;
> end;
> $procedure$;

I think you're out of luck on that.  Releases before last November
ignored that cast entirely, thinking it a no-op.  Current releases
do not ignore it, recognizing that in fact it has to be understood
as casting to varchar-of-unspecified-length.  But then the argument
isn't a bare variable anymore.

We debated about whether to back-patch such a behavioral change,
and maybe we shouldn't have.  But there are scenarios in which
the old behavior makes it just impossible to do things, eg you
may not be able to get a UNION to produce the desired type.
On balance we felt this was a bug fix.

			regards, tom lane