From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hamid Akhtar <hamid.akhtar@gmail.com>
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16346: pg_upgrade fails on a trigger with a comment
In-reply-to: 
 <CANugjhsTWXx8bEsZU5+RVYHNd5bezeX-cv4LSauBRYx27Ckbuw@mail.gmail.com>
References: <16346-6210ad7a0ea81be1@postgresql.org>
 <CANugjhsWLbJsgTCQkm1du3BRZXsCBPFSrmPn0oyDKVWWr6HS_w@mail.gmail.com>
 <CANugjhsTWXx8bEsZU5+RVYHNd5bezeX-cv4LSauBRYx27Ckbuw@mail.gmail.com>
Comments: In-reply-to Hamid Akhtar <hamid.akhtar@gmail.com>
	message dated "Wed, 08 Apr 2020 12:21:32 +0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29775.1586360057.1@sss.pgh.pa.us>
Date: Wed, 08 Apr 2020 11:34:17 -0400
Message-ID: <29776.1586360057@sss.pgh.pa.us>
Precedence: bulk

Hamid Akhtar <hamid.akhtar@gmail.com> writes:
> To recap, the attached patch moves restoration of comments to the
> RESTORE_PASS_POST_ACL. This ensures that comments are
> restored in a PASS when essentially all required objects are created
> including event triggers and materialized views (and any other db
> objects).

This is surely not a good idea as it stands, because it delays restore
of *all* object comments to the very end.  That's not nice for parallel
restores, and it also has large impact on pg_dump's behavior in cases
that have nothing to do with event triggers; which could cause unforeseen
problems.

The right way is to postpone only event trigger comments.  I fixed it
that way and pushed it.

			regards, tom lane