From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
In-reply-to: <20190823015921.GD2328@paquier.xyz>
References: <30820.1566397711@sss.pgh.pa.us>
 <20190821143449.GA27852@alvherre.pgsql> <20190822014739.GB1683@paquier.xyz>
 <20190822150945.3xgbvk7qqyqkyjse@alap3.anarazel.de>
 <20190823015921.GD2328@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 23 Aug 2019 10:59:21 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29796.1566572294.1@sss.pgh.pa.us>
Date: Fri, 23 Aug 2019 10:58:14 -0400
Message-ID: <29797.1566572294@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> The latest patch does that:
> +    pg_log_fatal("too many jobs for this platform's select() -- try %d"
> Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?

That seems over-punctuated, plus it burdens the reader with unnecessary
detail.  Most SQL folk would be confused by the reference to SELECT,
I bet.  (In fact, don't we have a style guideline against mentioning
particular syscalls?)

How about just "too many jobs for this platform -- try %d" ?

			regards, tom lane