Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCx0F-0007U9-Rn for pgsql-bugs@arkaria.postgresql.org; Fri, 19 Feb 2021 04:02:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lCx0E-0000Xq-1U for pgsql-bugs@arkaria.postgresql.org; Fri, 19 Feb 2021 04:02:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCx0D-0000Xh-Rn for pgsql-bugs@lists.postgresql.org; Fri, 19 Feb 2021 04:02:49 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCx0A-0006EU-UD for pgsql-bugs@lists.postgresql.org; Fri, 19 Feb 2021 04:02:48 +0000 Received: from hnk.local (p2710230-ipbf1703funabasi.chiba.ocn.ne.jp [123.216.93.230]) by oss.nttdata.com (Postfix) with ESMTPSA id 1D7EC627E6; Fri, 19 Feb 2021 13:02:43 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: BUG #16867: savepoints vs. commit and chain To: Vik Fearing , Arthur Nascimento Cc: pgsql-bugs@lists.postgresql.org References: <16867-3475744069228158@postgresql.org> <473dba6b-dfb3-b5a8-93c6-af3787893728@oss.nttdata.com> <38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org> From: Fujii Masao Message-ID: <29ba82f2-c2b6-dde2-5817-4b3558c4cadd@oss.nttdata.com> Date: Fri, 19 Feb 2021 13:02:42 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021/02/18 23:10, Vik Fearing wrote: > On 2/18/21 2:58 PM, Fujii Masao wrote: >> >> >> On 2021/02/17 3:03, Arthur Nascimento wrote: >>> Hi, Fujii-san, >>> >>> On Tue, 16 Feb 2021 at 01:49, Fujii Masao >>> wrote: >>>> In the server side, ISTM that CommitTransactionCommand() needs to handle >>>> the COMMIT AND CHAIN in TBLOCK_SUBCOMMIT case, but it forgot to do that. >>>> Patch attached. I'm not sure if this is a bug or an intentional >>>> behavior. >>>> Probably we need to look at the past discussion about AND CHAIN feature. >>> >>> I can confirm that your patch solved it for me. Thanks for looking >>> into it. >> >> Thanks for testing the patch! >> >> As far as I read the past discussion about chain transaction, >> I could not find any mention that current behavior that you reported >> is intentional. >> >> Barring any objection, I will commit the patch that you wrote >> for psql and the patch I wrote. > > No objection from me. According to the standard, a COMMIT should > destroy all savepoints and terminate the transaction, even if AND CHAIN > is specified. You imply that the standard says that COMMIT AND CHAIN should just terminate the transaction if there are savepoints defined, i.e., should not start new transaction? Since I can (maybe wrongly) interpret your comment like that, please let me confirm what the standard says just in case. I was thinking that COMMIT AND CHAIN should destroy all the savepoints, terminate the transaction and start new transaction with the same transaction characteristics immediately. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION