Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: BUG #15727: PANIC: cannot abort transaction 295144144,
 it was already committed
From: =?utf-8?B?0JbQsNGA0LrQvtCyINCg0L7QvNCw0L0=?= <r.zharkov@postgrespro.ru>
In-Reply-To: <1492.1554225238@sss.pgh.pa.us>
Date: Wed, 3 Apr 2019 00:35:47 +0700
Cc: Andres Freund <andres@anarazel.de>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <2BD617B6-CC34-42EF-8D79-4669C5DFB8D1@postgrespro.ru>
References: <30650.1554219866@sss.pgh.pa.us>
 <20190402155108.GA17787@alvherre.pgsql>
 <20190402161320.o5wkbp7evuzqe4c2@alap3.anarazel.de>
 <b5d89910ec01a657530d1a49ff0e05dc@postgrespro.ru>
 <1492.1554225238@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Precedence: bulk


> 3 =D0=B0=D0=BF=D1=80. 2019 =D0=B3., =D0=B2 0:13, Tom Lane <tgl@sss.pgh.pa.=
us> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
>=20
> r.zharkov@postgrespro.ru writes:
>> I made the new core file:
>=20
> Thanks, but this isn't much help --- it just shows what we already
> know, ie the "cannot abort transaction" error occurs after some other
> error was thrown.
>=20
> What would be more helpful would be to adjust the places that
> can throw the "unexpected table_lock_tuple status" error text to be
> PANIC rather than ERROR, so that the core dump would show a stack
> trace showing how we got to whichever of those places this is.
> Or, run the test with a higher log verbosity, so that you can find
> out which of those places is throwing the error to begin with;
> then just PANIC-ize that one.
>=20
> FWIW, I see six potential candidates, not two:
>=20
> pgsql/src/backend/commands/trigger.c: 3380:                elog(ERROR, "un=
expected table_lock_tuple status: %u", test);
> pgsql/src/backend/executor/nodeLockRows.c: 232:                elog(ERROR,=
 "unexpected table_lock_tuple status: %u",
> pgsql/src/backend/executor/nodeModifyTable.c: 881:                        =
    elog(ERROR, "unexpected table_lock_tuple status: %u",
> pgsql/src/backend/executor/nodeModifyTable.c: 1384:                       =
     elog(ERROR, "unexpected table_lock_tuple status: %u",
> pgsql/src/backend/executor/execReplication.c: 211:                elog(ERR=
OR, "unexpected table_lock_tuple status: %u", res);
> pgsql/src/backend/executor/execReplication.c: 375:                elog(ERR=
OR, "unexpected table_lock_tuple status: %u", res);
>=20
>=20
>            regards, tom lane

Ok. I will made it tomorrow morning.

regards,
Roman Zharkov=