Message-ID: <2a35c8f8-b610-412c-b234-2570e2b97a37@iki.fi>
Date: Wed, 3 Dec 2025 11:13:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #19343: toast_internals.c:139:2: warning: missing braces
 around initializer [-Wmissing-braces]
To: natalie.reno@cchmc.org, pgsql-bugs@lists.postgresql.org,
 Peter Eisentraut <peter@eisentraut.org>
References: <19343-bac8653701266869@postgresql.org>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <19343-bac8653701266869@postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2a35c8f8-b610-412c-b234-2570e2b97a37%40iki.fi>
Precedence: bulk

On 02/12/2025 21:41, PG Bug reporting form wrote:
> The following bug has been logged on the website:
`>
> Bug reference:      19343
> Logged by:          Natalie Reno
> Email address:      natalie.reno@cchmc.org
> PostgreSQL version: 16.11
> Operating system:   RHEL7
> Description:
> 
> When compiling the latest version, 16.11, I received the following error:
> gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Werror=vla -Wendif-labels
> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv
> -fexcess-precision=standard -O2 -I../../../../src/include -D_GNU_SOURCE
> -c -o toast_internals.o toast_internals.c
> toast_internals.c: In function ‘toast_save_datum’:
> toast_internals.c:139:2: warning: missing braces around initializer
> [-Wmissing-braces]
>    }   chunk_data = {0}; /* silence compiler warning */
>    ^
> toast_internals.c:139:2: warning: (near initialization for ‘chunk_data.hdr’)
> [-Wmissing-braces]
> 
> When I compared toast_internals.c files between 16.11 and 16.10, I found
> this difference that is supposed to account for silencing the compiler
> warning.
> 
> diff
> /u01/app/postgres/product/postgresql-16.11/src/backend/access/common/toast_internals.c
> /u01/app/postgres/product/postgresql-16.10/src/backend/access/common/toast_internals.c
> 139c139
> <       }                       chunk_data = {0};       /* silence compiler
> warning */ <-- 16.11
> ---
>>        }                       chunk_data; <-- 16.10

On 'master', this was done slightly differently, see commit 748caa9dcb. 
Peter decided to only do that bigger code rearrangement on 'master', and 
do the less invasive initialization on backbranches [1]. I think we 
should just backpatch the bigger code rearrangement too.

[1] 
https://www.postgresql.org/message-id/76f41fdc-69e1-43b4-b9aa-503b07980de1%40eisentraut.org

- Heikki