Message-ID: <2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net>
Date: Tue, 14 Jan 2025 16:12:37 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pg_rewind fails on Windows where tablespaces are used
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 Alexandra Wang <alexandra.wang.oss@gmail.com>,
 Chris Travers <chris.travers@stormatics.tech>,
 Farooq Rashed <farooq.rashed@desc.gov.ae>, pgsql-bugs@lists.postgresql.org
References: 
 <CA+pA0kLc5VxOaO4WfLjmh7W0V+quVvVtT5CaRVRAZMuh0zft4Q@mail.gmail.com>
 <Zl6dsK5IcNGTL0qD@paquier.xyz>
 <5169f6d5-240e-49ec-9265-ddafa6e863bd@dunslane.net>
 <Zo3D3Y24Kd1eTV8n@paquier.xyz>
 <CAK98qZ0PLMWRKe=_oHjxwKKDQHZ0wb5ntjiefWpe9V1r8J0b6w@mail.gmail.com>
 <ZxmAxLkKrDxc_0zx@paquier.xyz>
 <982f5caf-6536-4e9f-aeec-227f31114526@dunslane.net>
 <ZyAbpVS3t1tjN7a0@paquier.xyz>
 <CAD5tBc+q66kwQ=g1sbS6hesPEkjbUyFNghEG+V=vBrjsTOuDmQ@mail.gmail.com>
 <Zy1UTJpSnDdWsOsW@paquier.xyz>
 <CA+hUKGLbnv+pe3q1fYOVkLD3pMra7GuihfMxUN-1831YH9RYQg@mail.gmail.com>
 <5d8284d1-b7b2-4dfb-a686-429d9ae0b04e@dunslane.net>
 <039f5e85-6059-4c94-bf0b-20c38b9e24e3@dunslane.net>
 <CA+hUKGJDiwEtH3HnK8ZX=m1587jmHRCnnN_LP-cHCxUL6Gy59g@mail.gmail.com>
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: 
 <CA+hUKGJDiwEtH3HnK8ZX=m1587jmHRCnnN_LP-cHCxUL6Gy59g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2cfbe91b-06d1-4609-845c-135d8b5157f8%40dunslane.net>
Precedence: bulk


On 2025-01-08 We 10:38 PM, Thomas Munro wrote:
> On Thu, Jan 9, 2025 at 3:45 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Those patches didn't actually include any tests. I guess the best test
>> would be to create a chain of several junction points and then run
>> initdb on the leaf of the chain?
> Yeah I think the three interesting cases were initdb when run under
> junctions like these:
>
> 1.  Volume GUID format: mklink /J foo \\?\Volume{12341234-1234...},
> expected to break without patch
> 2.  Chain: mklink /J C:\\aaa1 C:\\aaa2, mkdir /J C:\\aaa2 c:\\aaa3,
> expected to break without patch
> 3.  Chain of length > 8, expected to fail with ELOOP once the patch is applied.
>
> (Syntax may be off, I just googled it but don't have Windows to try).
>
> The way to get decent tests for this stuff and all the rest of the
> wrappers would probably be to develop this test suite further:
>
> https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com


I can confirm that these two patches apply cleanly to releases 13 .. 15, 
that builds are also clean, and that tests 1..3 above pass/fail as 
expected. Tested on a WS2019 instance.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com