Subject: Re: BUG #17158: Distinct ROW fails with Postgres 14
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, sait.nisanci@microsoft.com,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
References: <17158-8a2ba823982537a4@postgresql.org>
 <CAApHDvp0w_5YY=7pxPkymtv7Oc0cGS=+jtiBvXrfcM6gLjT5Pg@mail.gmail.com>
 <bc0ec85a-68cf-1b99-e80c-ee0c55b936db@enterprisedb.com>
 <496046.1629843371@sss.pgh.pa.us>
 <c182f5c8-fdf3-80a0-fa43-4ed7e87d4d47@enterprisedb.com>
 <2021952.1630442634@sss.pgh.pa.us>
 <7fb17b3d-13dc-fc28-17ce-9c302d676bd8@enterprisedb.com>
 <4519d7da-7402-cff3-d577-0bc8511e0c9a@enterprisedb.com>
 <4092959.1631302070@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <2f0f926d-23c9-2ded-4032-dee85be733dc@enterprisedb.com>
Date: Tue, 14 Sep 2021 16:39:39 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <4092959.1631302070@sss.pgh.pa.us>
Content-Type: multipart/mixed;
 boundary="------------18AD61ACA43934C2F990960D"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/2f0f926d-23c9-2ded-4032-dee85be733dc%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------18AD61ACA43934C2F990960D
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 10.09.21 21:27, Tom Lane wrote:
> Perhaps it'd work to put the phony entry into fcinfo->flinfo->fn_mcxt
> instead of CacheMemoryContext.
> 
> BTW, skink's failure can be reproduced pretty quickly by running the
> attached under valgrind.

Ok, the attached patch fixes the valgrind error.

--------------18AD61ACA43934C2F990960D
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="0001-Fix-hash_array.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-Fix-hash_array.patch"