Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rRxec-00ASX5-4h for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Jan 2024 17:00:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rRxeb-005GhJ-Bd for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Jan 2024 17:00:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rRxeb-005Gh8-3h for pgsql-bugs@lists.postgresql.org; Mon, 22 Jan 2024 17:00:09 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rRxeY-002owP-1J for pgsql-bugs@lists.postgresql.org; Mon, 22 Jan 2024 17:00:07 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50eaa8b447bso3578458e87.1 for ; Mon, 22 Jan 2024 09:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705942803; x=1706547603; darn=lists.postgresql.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=zFiRvLk0cAbCM27cknbWitkoXXuIA2eFYub0e/58PBo=; b=VxglQ8zk5UfsYvLOLd6ZlMD+1GH5fCsQUecXvdIr+WkOc5VcJm8av8sk9qWNFr2jO8 9M2U/pCbo/rq6AELdojAqDXEpecKyIHNd+8Ie5SZ/+WfvcjmCjSF8rlI+L3qcq1lJHa8 YuxDMQghDVZ5SrkmY5YsTFfPcp8r85BlsQRWD83ekPdWx6okjCiUE1wBYt4Jr/FIdt04 1OhmKFtWVtRaQZj9o3mV/j3honpg4yOXGQXqlJL/93hFINgorLfDKZogiGUhxkRDFQ2w 1/OPY1aqNJToumOTw+Z26M4y+HlajpMXTBA0IjXQeznRWp2jOxFGgpAqXNKTkpWcQPsk mkvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705942803; x=1706547603; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zFiRvLk0cAbCM27cknbWitkoXXuIA2eFYub0e/58PBo=; b=Whfdza05k5XtWd3VXGrN4dUtG75KYYmJGns2DNtylyWB0QpbfYNpZcpg5zLyXEYQ8C GDru08opvLK6Toq1xb75Xs7Mi2eQDZIMtPewuPTIiD2EACvlX5yonv3/iHhVSvJT5Go/ FPwm2VkPrKIuWNpOP8DUvNrfk4jpTST0/7MgHJVhYFtfrM07G1jNkxezteyA4qK8kOi4 NZB5LmrlldwdzD/GlAjZnrRc3AsZlFUjqv4u86jA2kVCKDfIcrY+cMO2tOWcFn6o06zs qFgRqT350K+8rSqNoWKbRxEvTuyLA5nxDpJOI5QWG2KK5zV3xxql3y77Y2ae/yXEk/tl W9hg== X-Gm-Message-State: AOJu0YzvPCoHAln7YaK/FiJJzeZG77u2Sm6WjpC4LlU6V7xbH2qGqtas RElUbG57nK/LRfxBh4fAzm5A48qbQtxizRWsHQ2poxk5VfB3Pyqy X-Google-Smtp-Source: AGHT+IG1JXjkWtZHvCO8Pd9BS1B64DssX0B23XFeEo/vN0dALfP1w918xJRagVbfSqOCjGTM6JllPw== X-Received: by 2002:a05:6512:2216:b0:50e:7f88:d34f with SMTP id h22-20020a056512221600b0050e7f88d34fmr864518lfu.57.1705942803200; Mon, 22 Jan 2024 09:00:03 -0800 (PST) Received: from [1.0.0.7] ([91.185.77.50]) by smtp.gmail.com with ESMTPSA id ep12-20020a056512484c00b0050e7bb5361fsm2057501lfb.298.2024.01.22.09.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 09:00:02 -0800 (PST) Content-Type: multipart/alternative; boundary="------------2idPTdQ4pSQ5GX0tfdMUxUtz" Message-ID: <2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com> Date: Mon, 22 Jan 2024 20:00:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance Content-Language: en-US To: Tender Wang Cc: Richard Guo , pgsql-bugs@lists.postgresql.org References: <18297-b04cd83a55b51e35@postgresql.org> <38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com> <9481c16e-8477-eb73-4e20-91bb1a13e2e0@gmail.com> From: Alexander Lakhin In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------2idPTdQ4pSQ5GX0tfdMUxUtz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, 22.01.2024 13:36, Tender Wang wrote: > > Yes, I've encountered a similar issue, this time with ALTER (TEXT SEARCH > CONFIGURATION): > CREATE TEXT SEARCH CONFIGURATION ispell_tst (COPY=english); > CREATE TEXT SEARCH DICTIONARY ispell (Template=ispell, DictFile=ispell_sample, AffFile=ispell_sample); > ALTER TEXT SEARCH CONFIGURATION ispell_tst ALTER MAPPING FOR word, word WITH ispell; > ERROR:  tuple already updated by self > > > Yes, this is another issue that DDL operation on an same object twice. Maybe we can report error on Parse phase. > But as you say, all the other DDL commands run OK, so maybe it's better to process this case in execution phase. > I will send a patch later. Thank you for working on this! As these two cases look like exceptions to the common behavior, I wonder whether we need some extra functions to deal with duplicates. (I haven't look yet how such duplicates processed for other object types.) > > And I'm just curious that how do you find these issues? Use some tools? I discovered these two issues with my kind of fuzzer, just watching out for the interesting errors. Best regards, Alexander --------------2idPTdQ4pSQ5GX0tfdMUxUtz Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Hi,

22.01.2024 13:36, Tender Wang wrote:

Yes, I've encountered a similar issue, this time with ALTER (TEXT SEARCH
CONFIGURATION):
CREATE TEXT SEARCH CONFIGURATION ispell_tst (COPY=english);
CREATE TEXT SEARCH DICTIONARY ispell (Template=ispell, DictFile=ispell_sample, AffFile=ispell_sample);
ALTER TEXT SEARCH CONFIGURATION ispell_tst ALTER MAPPING FOR word, word WITH ispell;
ERROR:  tuple already updated by self

Yes, this is another issue that DDL operation on an same object twice. Maybe we can report error on Parse phase.
But as you say, all the other DDL commands run OK, so maybe it's better to process this case in execution phase.
I will send a patch later.

Thank you for working on this!

As these two cases look like exceptions to the common behavior, I wonder
whether we need some extra functions to deal with duplicates.
(I haven't look yet how such duplicates processed for other object types.)


And I'm just curious that how do you find these issues? Use some tools?
 

I discovered these two issues with my kind of fuzzer, just watching out
for the interesting errors.

Best regards,
Alexander
--------------2idPTdQ4pSQ5GX0tfdMUxUtz--