Subject: Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when
 extracting epoch
To: pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CA+hUKGK+K8NyS57tU841m1tSF6ha3W0udN2dw_Hbc=D_0OPbmA@mail.gmail.com>
 <ee683994-8f7c-aded-be43-543e66e68b94@2ndquadrant.com>
 <a3be61d9-f44b-7fce-3dc8-d700fdfb6f48@2ndquadrant.com>
 <CAFj8pRC8cgoiQMT235cky4Pa40gj=s0m3PftmaJLSt9MAiwj_Q@mail.gmail.com>
 <be30c07c-3f7b-7c86-f1c5-d0858046b26f@2ndquadrant.com>
 <1551357.1599435992@sss.pgh.pa.us>
 <097a4242-0748-98e3-06ab-ded1d366cd76@2ndquadrant.com>
 <1893468.1599658711@sss.pgh.pa.us>
 <38fc499a-ae52-efb6-aad6-82f812d6782d@2ndquadrant.com>
 <20200917055327.GU2873@paquier.xyz> <20200930071543.GL1996@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pavel Stehule <pavel.stehule@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>,
 Petr Fedorov <petr.fedorov@phystech.edu>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <2fb99632-9302-6509-78ce-3aaed3fd7f40@2ndquadrant.com>
Date: Tue, 15 Dec 2020 15:03:31 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200930071543.GL1996@paquier.xyz>
Content-Type: multipart/mixed;
 boundary="------------B62791CD335383A2A55B53DB"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------B62791CD335383A2A55B53DB
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Here is a new patch for this.  This now follows the implementation that 
Tom has suggested:  Leave date_part() alone, add a new set of extract() 
functions, and map the SQL EXTRACT construct to those.  I have basically 
just copied over the implementations from my previous patch and placed 
them next to the existing date_part() implementations.  So all the 
behavior is still the same as in the previous patches.

One thing I still need to look into is how to not lose all the test 
coverage for date_part().  But that should be fairly mechanical, so I'm 
leaving it off in this version.

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/

--------------B62791CD335383A2A55B53DB
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="v4-0001-Change-return-type-of-EXTRACT-to-numeric.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="v4-0001-Change-return-type-of-EXTRACT-to-numeric.patch"