pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
BUG #19080: CancelRequest message documentation bug
6+ messages / 4 participants
[nested] [flat]

* BUG #19080: CancelRequest message documentation bug
@ 2025-10-09 13:39 PG Bug reporting form <noreply@postgresql.org>
  2025-10-10 03:16 ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
  2025-10-14 02:06 ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
  0 siblings, 2 replies; 6+ messages in thread

From: PG Bug reporting form @ 2025-10-09 13:39 UTC (permalink / raw)
  To: pgsql-bugs@lists.postgresql.org; +Cc: doomedseer@gmail.com

The following bug has been logged on the website:

Bug reference:      19080
Logged by:          Artem Bezborodko
Email address:      doomedseer@gmail.com
PostgreSQL version: 18.0
Operating system:   N/A
Description:        

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: BUG #19080: CancelRequest message documentation bug
  2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
@ 2025-10-10 03:16 ` John Naylor <johncnaylorls@gmail.com>
  2025-10-14 11:39   ` Re: BUG #19080: CancelRequest message documentation bug Heikki Linnakangas <hlinnaka@iki.fi>
  1 sibling, 1 reply; 6+ messages in thread

From: John Naylor @ 2025-10-10 03:16 UTC (permalink / raw)
  To: doomedseer@gmail.com; pgsql-bugs@lists.postgresql.org; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>

On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
> Starting from 18 version field "Length of message contents in bytes,
> including self." should not have predefined value, due to variable key
> length. Now it set as (16).

Seems like an oversight, since the docs describe the v3.2 protocol.
I've attached a fix and CC'd the committer to confirm.

-- 
John Naylor
Amazon Web Services

Attachments:

  [text/x-patch] protocol-varlen-cancelrequest.patch (476B, ../../CANWCAZZfDH1QtsdQYWoRqjow2r_DVO0TFdUYgqWG+UKsOP+69A@mail.gmail.com/2-protocol-varlen-cancelrequest.patch)
  download | inline diff:
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index b5395604fb8..9d755232873 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -4327,7 +4327,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
     <listitem>
      <variablelist>
       <varlistentry>
-       <term>Int32(16)</term>
+       <term>Int32</term>
        <listitem>
         <para>
          Length of message contents in bytes, including self.


^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: BUG #19080: CancelRequest message documentation bug
  2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
  2025-10-10 03:16 ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
@ 2025-10-14 11:39   ` Heikki Linnakangas <hlinnaka@iki.fi>
  2025-10-15 02:30     ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
  0 siblings, 1 reply; 6+ messages in thread

From: Heikki Linnakangas @ 2025-10-14 11:39 UTC (permalink / raw)
  To: John Naylor <johncnaylorls@gmail.com>; doomedseer@gmail.com; pgsql-bugs@lists.postgresql.org; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>

On 10 October 2025 05:16:32 CEST, John Naylor <johncnaylorls@gmail.com> 
wrote:
>On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
><noreply@postgresql.org> wrote:
>> Starting from 18 version field "Length of message contents in bytes,
>> including self." should not have predefined value, due to variable key
>> length. Now it set as (16).
>
>Seems like an oversight, since the docs describe the v3.2 protocol.
>I've attached a fix and CC'd the committer to confirm.

Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

- Heikki





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: BUG #19080: CancelRequest message documentation bug
  2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
  2025-10-10 03:16 ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
  2025-10-14 11:39   ` Re: BUG #19080: CancelRequest message documentation bug Heikki Linnakangas <hlinnaka@iki.fi>
@ 2025-10-15 02:30     ` John Naylor <johncnaylorls@gmail.com>
  2025-10-15 08:09       ` Re: BUG #19080: CancelRequest message documentation bug Magnus Hagander <magnus@hagander.net>
  0 siblings, 1 reply; 6+ messages in thread

From: John Naylor @ 2025-10-15 02:30 UTC (permalink / raw)
  To: Heikki Linnakangas <hlinnaka@iki.fi>; +Cc: doomedseer@gmail.com; pgsql-bugs@lists.postgresql.org

On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

This has been fixed already, since it was reported on the pgsql-docs
list but I didn't see that until it was committed.

-- 
John Naylor
Amazon Web Services





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: BUG #19080: CancelRequest message documentation bug
  2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
  2025-10-10 03:16 ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
  2025-10-14 11:39   ` Re: BUG #19080: CancelRequest message documentation bug Heikki Linnakangas <hlinnaka@iki.fi>
  2025-10-15 02:30     ` Re: BUG #19080: CancelRequest message documentation bug John Naylor <johncnaylorls@gmail.com>
@ 2025-10-15 08:09       ` Magnus Hagander <magnus@hagander.net>
  0 siblings, 0 replies; 6+ messages in thread

From: Magnus Hagander @ 2025-10-15 08:09 UTC (permalink / raw)
  To: John Naylor <johncnaylorls@gmail.com>; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>; doomedseer@gmail.com; pgsql-bugs@lists.postgresql.org

On Wed, 15 Oct 2025 at 04:30, John Naylor <johncnaylorls@gmail.com> wrote:

> On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi>
> wrote:
> > Yep, thanks! Feel free to commit the fix, or I can do it on Friday
> myself.
>
> This has been fixed already, since it was reported on the pgsql-docs
> list but I didn't see that until it was committed.
>

Yeah, and I didn't see the one on -bugs until you pointed it out. Sorry
about that!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: BUG #19080: CancelRequest message documentation bug
  2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
@ 2025-10-14 02:06 ` John Naylor <johncnaylorls@gmail.com>
  1 sibling, 0 replies; 6+ messages in thread

From: John Naylor @ 2025-10-14 02:06 UTC (permalink / raw)
  To: doomedseer@gmail.com; pgsql-bugs@lists.postgresql.org

On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
> Starting from 18 version field "Length of message contents in bytes,
> including self." should not have predefined value, due to variable key
> length. Now it set as (16).

This was reported last week on the pgsql-docs list, and has been fixed:

https://www.postgresql.org/message-id/CAAfz9KML7JCZWZsOc2AWgoUHgmRGoOAOR6L%3DxDFe9F3_L1uXAQ%40mail.g...

-- 
John Naylor
Amazon Web Services





^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2025-10-15 08:09 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-10-09 13:39 BUG #19080: CancelRequest message documentation bug PG Bug reporting form <noreply@postgresql.org>
2025-10-10 03:16 ` John Naylor <johncnaylorls@gmail.com>
2025-10-14 11:39   ` Heikki Linnakangas <hlinnaka@iki.fi>
2025-10-15 02:30     ` John Naylor <johncnaylorls@gmail.com>
2025-10-15 08:09       ` Magnus Hagander <magnus@hagander.net>
2025-10-14 02:06 ` John Naylor <johncnaylorls@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox