From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: Richard Guo <guofenglinux@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17858: ExecEvalArrayExpr() leaves uninitialised memory for
 multidim array with nulls
In-reply-to: <87461d66-e96b-24f8-3e66-1daf937fff98@gmail.com>
References: <17858-8fd287fd3663d051@postgresql.org>
 <CAMbWs48CyDghUckGQbkbAB6uPdfzYS4X4Zkdfooausr5vaV9Bg@mail.gmail.com>
 <4240d86f-7e9f-388b-fd96-f8944860c0f5@gmail.com>
 <1216375.1679408668@sss.pgh.pa.us>
 <CAMbWs4_=kd4-u3Mh3tV+NcHuSGY-9Fax+Ck1ZVzOV0HzJ6dXow@mail.gmail.com>
 <87461d66-e96b-24f8-3e66-1daf937fff98@gmail.com>
Comments: In-reply-to Alexander Lakhin <exclusion@gmail.com>
	message dated "Sun, 26 Mar 2023 07:00:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3008682.1679852681.1@sss.pgh.pa.us>
Date: Sun, 26 Mar 2023 13:44:41 -0400
Message-ID: <3008683.1679852681@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3008683.1679852681%40sss.pgh.pa.us>
Precedence: bulk

Alexander Lakhin <exclusion@gmail.com> writes:
> So maybe the fix for the bug can be seen as a supplement for 18c0b4ecc.

Yeah, I agree.  Given that precedent, there's little excuse for
ExecEvalArrayExpr not to use palloc0; the fact that it doesn't
already was just an oversight in 18c0b4ecc.

I realized that there's a completely separate way in which
ExecEvalArrayExpr is a few bricks shy of a load: it fails to check
for overflow of the output array size.

Pushed the discussed changes along with a fix for that.

			regards, tom lane