From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
cc: Richard Guo <guofenglinux@gmail.com>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Assert failure with ICU support
In-reply-to: <ece303a3068026c6d6f10cab2a7f3f0836f4adb7.camel@j-davis.com>
References: 
 <CAMbWs49Q6UoKGeT8pBkMtJGJd+16CBFZaaWUk9Du+2ERE5g_YA@mail.gmail.com>
 <ece303a3068026c6d6f10cab2a7f3f0836f4adb7.camel@j-davis.com>
Comments: In-reply-to Jeff Davis <pgsql@j-davis.com>
	message dated "Wed, 19 Apr 2023 13:31:17 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3017541.1681937148.1@sss.pgh.pa.us>
Date: Wed, 19 Apr 2023 16:45:48 -0400
Message-ID: <3017542.1681937148@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3017542.1681937148%40sss.pgh.pa.us>
Precedence: bulk

Jeff Davis <pgsql@j-davis.com> writes:
> We should probably just check that it's plain ASCII.

That was about the same conclusion I came to.  More or less

	c = *v->now++;
-	if (!iscalnum(c))
+	if (!isascii(c) || !iscalnum(c))
		RETV(PLAIN, c);

although I'm not sure if it's a good idea to apply isascii()
to something that's wider than char.  It might be advisable,
if ugly, to write

+	if (c >= 0x100 || !iscalnum(c))

I'm also inclined to remove that "assert(iscalpha(c))" in
the switch.  That's not checking sanity of our own code,
just consistency of the <wctype.h> functions; and as this
episode shows it's more trouble than it's worth.

			regards, tom lane