From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        "zedaardv@drizzle.com" <zedaardv@drizzle.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17720: pg_dump creates a dump with primary key that cannot
 be restored, when specifying 'using index ...'
In-reply-to: <20CD10FD-A9C2-47D0-9A75-B86532BC058E@yesql.se>
References: <17720-dab8ee0fa85d316d@postgresql.org>
 <CAKFQuwam=1NoSNH=EJRUnuuD8JE_jM8tq22-SYqO1nxzoXFwzg@mail.gmail.com>
 <9C039DE3-EFBD-4D65-B4CF-90D8148B7B4C@yesql.se>
 <2684951.1671032222@sss.pgh.pa.us>
 <20CD10FD-A9C2-47D0-9A75-B86532BC058E@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 14 Dec 2022 23:30:54 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3039076.1671060472.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 14 Dec 2022 18:27:52 -0500
Message-ID: <3039077.1671060472@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3039077.1671060472%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> The attached prohibits the use of NULLS NOT DISTINCT for backing primary=
 key
> constraints but allow them for unique constraints.  Is this along the li=
nes of
> what you had in mind?

Needs more than zero comments in the code, and why bother testing
is_alter_table in index_check_primary_key?  We're disallowing
this case across-the-board, no matter how you get to it.

I'll defer to Peter on whether this is in fact the right way to go,
or we should relax the syntax restriction as David suggests.

			regards, tom lane