From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: pm91.arapov@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18845: DEREF_OF_NULL.RET guc_malloc possibly returns NULL
In-reply-to: <A664B6DF-7D34-4004-AC89-66B1517B3301@yesql.se>
References: <18845-582c6e10247377ec@postgresql.org>
 <A664B6DF-7D34-4004-AC89-66B1517B3301@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Fri, 14 Mar 2025 14:50:46 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3051192.1741961099.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 14 Mar 2025 10:04:59 -0400
Message-ID: <3051193.1741961099@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3051193.1741961099%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Why would we want FATAL here?  Wouldn't it be better to return false lik=
e how
> other check_ functions already do?

Indeed.  Also, a quick survey shows a lot of inconsistency in
guc_malloc callers --- some are lazy and just use ERROR rather
than LOG-and-return.  That's probably all right for PGC_POSTMASTER
variables (since there's no chance of continuing anyway) but
perhaps it's worth improving elsewhere.

			regards, tom lane