From: Tom Lane <tgl@sss.pgh.pa.us>
To: wliang@stu.xidian.edu.cn
cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: Report a potential memory leak in describeOneTableDetails()
In-reply-to: <110a333f.359.17efb204b17.Coremail.wliang@stu.xidian.edu.cn>
References: <110a333f.359.17efb204b17.Coremail.wliang@stu.xidian.edu.cn>
Comments: In-reply-to wliang@stu.xidian.edu.cn
	message dated "Tue, 15 Feb 2022 10:05:04 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3052376.1644943008.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 15 Feb 2022 11:36:48 -0500
Message-ID: <3052377.1644943008@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3052377.1644943008%40sss.pgh.pa.us>
Precedence: bulk

wliang@stu.xidian.edu.cn writes:
> I find a potential memory leak in PostgresSQL 14.1, which is in the func=
tion describeOneTableDetails (./src/bin/psql/describe.c).

Do you want to submit a patch?  The amount of memory involved here isn't
much, but since psql is a potentially long-running program, it seems worth
the trouble to be careful.

I think the best fix might be to drop these strdup's altogether, and
instead postpone freeing the PGresult to the end of the function, so
that we can just use the pointers returned by PQgetvalue.

			regards, tom lane