From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Viktor Holmberg <v@viktorh.net>, pgsql-bugs@lists.postgresql.org
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
In-reply-to: <51C655A4-46FB-4A40-BAE5-26A76B31D3EE@yesql.se>
References: <ae6ed432-4491-4030-be20-3ea69d03a098@Spark>
 <790bc1f9-74dc-4b50-94d2-8147315b1556@Spark>
 <51C655A4-46FB-4A40-BAE5-26A76B31D3EE@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Fri, 14 Mar 2025 14:29:55 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3052530.1741961784.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 14 Mar 2025 10:16:24 -0400
Message-ID: <3052531.1741961784@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3052531.1741961784%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 14 Mar 2025, at 12:49, Viktor Holmberg <v@viktorh.net> wrote:
>> The isn_weak function in the isn extension reports the wrong value if y=
ou look at it inside a transaction:

> I wonder if this should really be marked VOLATILE instead as it has a si=
de
> effect.

Indeed.  This whole area seems really poorly considered.  The comment
in isn--1.1.sql says

-- isn_weak(boolean) - Sets the weak input mode.
-- This function is intended for testing use only!

despite which it's documented at length in isn.sgml.  On the other
hand, so far as I can find it's tested nowhere, which means none
of the "weak mode" code is getting exercised.

			regards, tom lane