From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <ishii@postgresql.org>
cc: koichi.dbms@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18735: Specific multibyte character in psql file path
 command parameter for Windows
In-reply-to: <20241207.081412.2050532354647835961.ishii@postgresql.org>
References: <2751825.1733464455@sss.pgh.pa.us>
 <20241206.154248.1191531539866262856.ishii@postgresql.org>
 <2840430.1733510664@sss.pgh.pa.us>
 <20241207.081412.2050532354647835961.ishii@postgresql.org>
Comments: In-reply-to Tatsuo Ishii <ishii@postgresql.org>
	message dated "Sat, 07 Dec 2024 08:14:12 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3066300.1733530061.1@sss.pgh.pa.us>
Date: Fri, 06 Dec 2024 19:07:41 -0500
Message-ID: <3066301.1733530061@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3066301.1733530061%40sss.pgh.pa.us>
Precedence: bulk

Tatsuo Ishii <ishii@postgresql.org> writes:
> I think the encoding we need to supply to canonicalize_path() is not
> necessarily the same as client_encoding. For example we could set
> client_encoding to UTF-8 but use a file which has Shift-JIS encode
> file name.  I think what we really need to supply to
> canonicalize_path() is the "file system encoding", not
> client_encoding.

That was what I was thinking yesterday, but seems to me it could
not really work to have client_encoding set to UTF-8 while you're
trying to type an SJIS file name.  Even if your terminal program
doesn't mangle anything, it's likely that psqlscan.l will.

I suppose if we think that's the situation, we could try to translate
the file path names from UTF8 to SJIS.  But that's a chunk of
functionality that doesn't exist right now, plus I'm afraid it'd
often make things worse not better.  We don't have nearly as much
certainty as we could wish about which encoding incoming data is in.

			regards, tom lane