From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
cc: =?ISO-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
        Virender Singla <virender.cse@gmail.com>,
        pgsql-bugs@lists.postgresql.org, Aniket Jha <aniketkumarj@gmail.com>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-reply-to: <b0459688caa95c77f439bebf3b30341169986369.camel@cybertec.at>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql> <2939991.1740089974@sss.pgh.pa.us> <b0459688caa95c77f439bebf3b30341169986369.camel@cybertec.at>
Comments: In-reply-to Laurenz Albe <laurenz.albe@cybertec.at>
	message dated "Fri, 21 Feb 2025 08:18:12 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3073712.1740148903.1@sss.pgh.pa.us>
Date: Fri, 21 Feb 2025 09:41:43 -0500
Message-ID: <3073713.1740148903@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3073713.1740148903%40sss.pgh.pa.us>
Precedence: bulk

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> I have one question about the first patch:

>> -	if (addroleto || adminmembers || rolemembers)
>> +	if (addroleto || adminmembers || rolemembers || !superuser())
>> 		CommandCounterIncrement();

> That change seems unrelated to the problem at hand, and I don't see it
> mentioned in the commit message.  Is that an oversight you fixed on the
> fly?

Well, kinda, because the patch doesn't work without it.  The
problematic case is where none of those 3 flags are set and also
!superuser, so that we decide we need the default grant implemented a
few lines further down.  That grant now has an explicit reference to
the new roleid, and if we haven't CommandCounterIncrement'ed, the
pg_shdepend code will error out because it doesn't see the catalog
entry for roleid.

			regards, tom lane