From: Tom Lane <tgl@sss.pgh.pa.us>
To: Viktor Holmberg <v@viktorh.net>
cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-bugs@lists.postgresql.org
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
In-reply-to: <de89bd5c-9f51-4891-8a38-d03ed06ebd1d@Spark>
References: <ae6ed432-4491-4030-be20-3ea69d03a098@Spark>
 <790bc1f9-74dc-4b50-94d2-8147315b1556@Spark>
 <51C655A4-46FB-4A40-BAE5-26A76B31D3EE@yesql.se>
 <3052531.1741961784@sss.pgh.pa.us>
 <de89bd5c-9f51-4891-8a38-d03ed06ebd1d@Spark>
Comments: In-reply-to Viktor Holmberg <v@viktorh.net>
	message dated "Fri, 14 Mar 2025 14:28:01 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3074064.1741965229.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 14 Mar 2025 11:13:49 -0400
Message-ID: <3074065.1741965229@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3074065.1741965229%40sss.pgh.pa.us>
Precedence: bulk

Viktor Holmberg <v@viktorh.net> writes:
> I haven=E2=80=99t checked the source code, but yes the isn_weak feature =
has some footgun potential. As it doesn=E2=80=99t respect transactions, bu=
t rather sets a flag on session level, it=E2=80=99s easy for the =E2=80=9C=
isn weakness=E2=80=9D to leak out into a connection pool.

Yeah, really that ought to be a GUC I should think.  There isn't
anything well-designed about it ...

I found some prior discussion here:

https://www.postgresql.org/message-id/flat/C12AE0A2A752416C79F3EE81%40teje

but we don't seem to have pulled the trigger on changing anything.

			regards, tom lane