Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPUQ5-00026z-7k for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Sep 2021 18:41:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mPUQ2-0004J0-Qw for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Sep 2021 18:41:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPUQ2-0004Is-J7 for pgsql-hackers@lists.postgresql.org; Sun, 12 Sep 2021 18:41:34 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPUPz-0006yC-GX for pgsql-hackers@lists.postgresql.org; Sun, 12 Sep 2021 18:41:33 +0000 Received: (Authenticated sender: adsend@dunslane.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E920F240003; Sun, 12 Sep 2021 18:41:25 +0000 (UTC) Subject: Re: pg_upgrade test for binary compatibility of core data types To: Justin Pryzby , Jacob Champion Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, buschmann@nidsa.net, noah@leadboat.com, tomas.vondra@2ndquadrant.com, bruce@momjian.us, andres@anarazel.de References: <20210112041352.GY1849@telsasoft.com> <20210112171559.GO4320@momjian.us> <20210112172753.GC1849@telsasoft.com> <20210112175356.GP4320@momjian.us> <66753439-83ae-7be5-6e41-9537a6041a39@dunslane.net> <1575064.1615060903@sss.pgh.pa.us> <20210430183348.GQ27406@telsasoft.com> <20210912005116.GF26465@telsasoft.com> From: Andrew Dunstan Message-ID: <30b2e19c-b44d-ec0a-6ea6-789b8e2be004@dunslane.net> Date: Sun, 12 Sep 2021 14:41:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210912005116.GF26465@telsasoft.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 9/11/21 8:51 PM, Justin Pryzby wrote: > > @Andrew: did you have any comment on this part ? > > |Subject: buildfarm xversion diff > |Forking https://www.postgresql.org/message-id/20210328231433.GI15100@telsasoft.com > | > |I gave suggestion how to reduce the "lines of diff" metric almost to nothing, > |allowing a very small "fudge factor", and which I think makes this a pretty > |good metric rather than a passable one. > Somehow I missed that. Looks like some good suggestions. I'll experiment. (Note: we can't assume the presence of sed, especially on Windows). cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com