Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kRzWl-00048w-N8
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 15:14:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kRzWF-0005uy-2F
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 15:13:47 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kRzWE-0005uq-S1
	for pgsql-hackers@lists.postgresql.org; Mon, 12 Oct 2020 15:13:46 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kRzWC-0000Uk-NR
	for pgsql-hackers@lists.postgresql.org; Mon, 12 Oct 2020 15:13:45 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 09CFDcKR3100397;
	Mon, 12 Oct 2020 11:13:38 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?=
 <juanjo.santamaria@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>, Emil Iggland <emil@iggland.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15858: could not stat file - over 4GB
In-reply-to: 
 <CAC+AXB25aAHGzmrvKd97jQK3wjYHzbhb72wpvGym6OmFqpj5Sw@mail.gmail.com>
References: 
 <CAC+AXB2164H1JjSOPwf=PK5AhRVHSApzC5NAU-443HSu7RotSA@mail.gmail.com>
 <160209800917.1171.12856112208955258625.pgcf@coridan.postgresql.org>
 <2831747.1602274940@sss.pgh.pa.us>
 <CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com>
 <20201010122353.GA2985@paquier.xyz>
 <CAC+AXB0f-pGWb2Rx1amCRCpjKohKLQ4L+Vsy7JaeHVgwJgbnGA@mail.gmail.com>
 <2920041.1602351778@sss.pgh.pa.us>
 <CAC+AXB36ZK=yzRVR4PkKVU0PQEP2SpaFC-_eavOm99U=f0kAhw@mail.gmail.com>
 <20201011002452.GA6607@paquier.xyz> <2944395.1602376488@sss.pgh.pa.us>
 <20201012010108.GB2346@paquier.xyz> <3062457.1602473238@sss.pgh.pa.us>
 <CAC+AXB25aAHGzmrvKd97jQK3wjYHzbhb72wpvGym6OmFqpj5Sw@mail.gmail.com>
Comments: In-reply-to =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?=
 <juanjo.santamaria@gmail.com>
	message dated "Mon, 12 Oct 2020 14:33:32 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3100395.1602515618.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 12 Oct 2020 11:13:38 -0400
Message-ID: <3100396.1602515618@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

=3D?UTF-8?Q?Juan_Jos=3DC3=3DA9_Santamar=3DC3=3DADa_Flecha?=3D <juanjo.sant=
amaria@gmail.com> writes:
> On Mon, Oct 12, 2020 at 5:27 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> Why are we forcing errno=3DENOENT here?  Wouldn't it be correct to use
>>> _dosmaperr(GetLastError()) to get the correct errno?

>> Fair question.  Juan, was there some good reason not to look at
>> GetLastError() in this step?

> Uhm, a good question indeed, forcing errno serves no purpose there.

OK, changed.

			regards, tom lane