From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: samuel.horwitz@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14876: Segmentation fault with JSONB column used in store
 proc that gets used by view and later altered
In-reply-to: 
 <CAB7nPqTZ_M4xDOv1C_09u_mVbp48ObkJpKzK=TGFRksKmKmyzQ@mail.gmail.com>
References: <20171026184035.1471.82810@wrigleys.postgresql.org>
 <CAB7nPqTxBZ5GorM8bejJ0z1aQo0Z93ChRJ9gCV5zu8B=ZrARVg@mail.gmail.com>
 <26672.1509050556@sss.pgh.pa.us> <31441.1509055499@sss.pgh.pa.us>
 <CAB7nPqTZ_M4xDOv1C_09u_mVbp48ObkJpKzK=TGFRksKmKmyzQ@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Fri, 27 Oct 2017 17:37:29 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31241.1509152963.1@sss.pgh.pa.us>
Date: Fri, 27 Oct 2017 21:09:23 -0400
Message-ID: <31242.1509152963@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> Sorry for coming up late in the game. I can see that you have pushed a
> patch as d5b760e, but back-paddled a bit on d76886c. After some
> analysis of things around, I think that you got it right. One comment
> I have first though is that you could have used forboth as there is no
> point to go through the target list entries once there are no more
> aliases. Or target list entries marked as resjunk do not have an
> expended reference name?

Right, there's no entry in the outer RTE for resjunk columns.

(In practice, resjunk entries are at the end of the tlist so that it
wouldn't really matter, but I try to keep code from assuming that.)

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs