From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
cc: =?ISO-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
        Virender Singla <virender.cse@gmail.com>,
        pgsql-bugs@lists.postgresql.org, Aniket Jha <aniketkumarj@gmail.com>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-reply-to: <58e47d097ed2a1512f47891293a7102d573fc970.camel@cybertec.at>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql> <2939991.1740089974@sss.pgh.pa.us> <b0459688caa95c77f439bebf3b30341169986369.camel@cybertec.at> <3073713.1740148903@sss.pgh.pa.us> <58e47d097ed2a1512f47891293a7102d573fc970.camel@cybertec.at>
Comments: In-reply-to Laurenz Albe <laurenz.albe@cybertec.at>
	message dated "Fri, 21 Feb 2025 17:23:24 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3137105.1740155469.1@sss.pgh.pa.us>
Date: Fri, 21 Feb 2025 11:31:09 -0500
Message-ID: <3137106.1740155469@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3137106.1740155469%40sss.pgh.pa.us>
Precedence: bulk

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> Thanks for the explanation.  That might be worth a comment.

The adjacent comment already says

	/*
	 * Advance command counter so we can see new record; else tests in
	 * AddRoleMems may fail.
	 */

so I didn't see anything to add there.  Maybe "We can skip this in
cases where we will not call AddRoleMems"?  Or maybe the better answer
is to conclude that the whole idea of not calling
CommandCounterIncrement unconditionally is too fragile and not worth
expending brain cells on, and just rip out the if-test.

			regards, tom lane