From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
cc: Jeremy Evans <code@jeremyevans.net>,
 Michael Paquier <michael@paquier.xyz>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
In-reply-to: <874lezskcu.fsf@news-spur.riddles.org.uk>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
 <20180906215836.GP2726@paquier.xyz>
 <20180906222843.GF17425@jeremyevans.local>
 <20180907165103.GH17425@jeremyevans.local>
 <20180907175518.GI17425@jeremyevans.local>
 <20180907181522.GB32058@paquier.xyz> <20016.1536351535@sss.pgh.pa.us>
 <20180907204403.GC32058@paquier.xyz> <16558.1536407783@sss.pgh.pa.us>
 <18398.1536410055@sss.pgh.pa.us> <87o9d8rv08.fsf@news-spur.riddles.org.uk>
 <3979.1536433320@sss.pgh.pa.us> <6869.1536436921@sss.pgh.pa.us>
 <874lezskcu.fsf@news-spur.riddles.org.uk>
Comments: In-reply-to Andrew Gierth <andrew@tao11.riddles.org.uk>
	message dated "Sat, 08 Sep 2018 23:25:25 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31647.1536451185.1@sss.pgh.pa.us>
Date: Sat, 08 Sep 2018 19:59:45 -0400
Message-ID: <31648.1536451185@sss.pgh.pa.us>
Precedence: bulk

Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>  Tom> Hence we need to make sure that version-script filtering happens
>  Tom> on every ELF-based platform, not just the most popular ones. I see
>  Tom> that the FreeBSD and NetBSD stanzas in Makefile.shlib also have
>  Tom> "ifdef ELF_SYSTEM" portions, so probably we need to put the
>  Tom> version-script stuff into those too.

> I tested adding your patch into the FreeBSD stanza and it worked for me,
> FWIW. That was on a system which still has GNU ld, but I also tried a
> test program using ld.lld and the same option and version script file
> works.

Hm.  So I can reproduce the crash on NetBSD as well as OpenBSD, using
the test method I showed before ... but *not* on FreeBSD 11.0 x86_64,
even though that's certainly an ELF system.  So now I'm confused again.

			regards, tom lane