From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Sam James <sam@gentoo.org>, pgsql-bugs@lists.postgresql.org
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
In-reply-to: 
 <CA+hUKGLJnhpJBrsutH2aK91ARMS+XCez5P8XrR-kwdfSyLXGiQ@mail.gmail.com>
References: <87o72eo9iu.fsf@gentoo.org> <3073930.1731867112@sss.pgh.pa.us>
 <CA+hUKGJsuBiBcYnmJhGUNEg6Ud3n+C3K8c6em6RTOgu1E-dbwg@mail.gmail.com>
 <3160019.1731875201@sss.pgh.pa.us>
 <CA+hUKGLJnhpJBrsutH2aK91ARMS+XCez5P8XrR-kwdfSyLXGiQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Mon, 18 Nov 2024 10:18:30 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3169078.1731880169.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 17 Nov 2024 16:49:29 -0500
Message-ID: <3169079.1731880169@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3169079.1731880169%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Mon, Nov 18, 2024 at 9:26 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Fun.  Well, now that we insist on C99 support in all branches,
>> I wonder whether we can just remove all the non-stdbool support.
>> The one thing that looks tricky is that we insist on sizeof(bool)
>> being 1, but are there any remaining supported platforms where
>> it isn't?  The buildfarm doesn't have any examples.

> So far I have found only Apple/Darwin PPC (RIP), where this was
> occasionally an issue.

Yeah.  Well, what say we leave the "typedef unsigned char bool"
pathway in place, but set things up to use that only if sizeof
the stdbool type isn't 1 --- and then it's up to any hypothetical
users of that pathway to choose a compiler and compiler options
that won't choke on it.

			regards, tom lane