From: Tom Lane <tgl@sss.pgh.pa.us>
To: bchen90@163.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16666: Slight memory leak when running pg_ctl reload
In-reply-to: <16666-2c41a4eec61b03e1@postgresql.org>
References: <16666-2c41a4eec61b03e1@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Mon, 12 Oct 2020 13:32:13 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3197646.1602524271.1@sss.pgh.pa.us>
Date: Mon, 12 Oct 2020 13:37:51 -0400
Message-ID: <3197647.1602524271@sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> I found slighting memory leakage occured when running pg_ctl reload command
> for the following code segment(guc.c:6726-6740). When runing 'pg_ctl
> reload', for these string type PGC_POSTMASTER GUC variables like
> 'unix_socket_directories', the following code segment will leak newval's
> memery.

Yeah, you're right.  If there's a "newextra" chunk, that'll get
leaked too.

Even counting that, it's not very plausible that one would SIGHUP a
server often enough that the bloat would become obvious, since these
values typically aren't very large.  But it's clearly a bug.

Patch applied, thanks for the report!

			regards, tom lane