From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Sam James <sam@gentoo.org>, pgsql-bugs@lists.postgresql.org
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
In-reply-to: 
 <CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>
References: <87o72eo9iu.fsf@gentoo.org> <3073930.1731867112@sss.pgh.pa.us>
 <CA+hUKGJsuBiBcYnmJhGUNEg6Ud3n+C3K8c6em6RTOgu1E-dbwg@mail.gmail.com>
 <3160019.1731875201@sss.pgh.pa.us>
 <CA+hUKGLJnhpJBrsutH2aK91ARMS+XCez5P8XrR-kwdfSyLXGiQ@mail.gmail.com>
 <3169079.1731880169@sss.pgh.pa.us>
 <CA+hUKGJEnmapE7YYEfdJYZ-yGmcDpVGRrQ_eEVdcux26ZNJq_g@mail.gmail.com>
 <3175762.1731883847@sss.pgh.pa.us>
 <CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Mon, 18 Nov 2024 14:30:38 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3198437.1731895163.1@sss.pgh.pa.us>
Date: Sun, 17 Nov 2024 20:59:23 -0500
Message-ID: <3198438.1731895163@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3198438.1731895163%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> I found a few lines we could just delete in master.  I wonder if we
> should also just require sizeof(bool) == 1 more explicitly going
> forward with an error, since we don't have coverage or any expectation
> of ever getting any for the alternative code AFAICS, even if it is
> small.

Yeah, that's a fair criticism.  I don't think we've tested that code
path since I retired prairiedog, so who's to say that it works even
now?  Maybe it's best to just delete that code, and if we ever find a
new platform with wider bool, figure out what to do at that time.

			regards, tom lane