Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKA18-00073D-Tt for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Feb 2022 02:26:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nKA17-0004c3-JW for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Feb 2022 02:26:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKA17-0004bu-B2 for pgsql-bugs@lists.postgresql.org; Wed, 16 Feb 2022 02:26:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKA14-0002Md-18 for pgsql-bugs@lists.postgresql.org; Wed, 16 Feb 2022 02:26:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21G2PwNV3243400; Tue, 15 Feb 2022 21:25:58 -0500 From: Tom Lane To: Andres Freund cc: Daniel Gustafsson , wliang@stu.xidian.edu.cn, pgsql-bugs Subject: Re: Report a potential memory leak in setup_config() In-reply-to: <20220216022118.vvijtgd5rl2b6ucv@alap3.anarazel.de> References: <64ee7543.20d.17efb1270ca.Coremail.wliang@stu.xidian.edu.cn> <3052163.1644942806@sss.pgh.pa.us> <20220216012953.6d7bzmsblqou3ru4@alap3.anarazel.de> <3239746.1644975946@sss.pgh.pa.us> <20220216022118.vvijtgd5rl2b6ucv@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 15 Feb 2022 18:21:18 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3243398.1644978358.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Feb 2022 21:25:58 -0500 Message-ID: <3243399.1644978358@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > I was pondering initdb's design a bunch lately. So I started a -hackers = thread: > https://postgr.es/m/20220216021219.ygzrtb3hd5bn7olz%40alap3.anarazel.de Yeah, I read that. I think making the backend read these files directly makes a ton of sense, so I'm no longer very excited about improving the performance or memory consumption of the replace_token stuff. I think we should put this thread on hold until someone does that, and then maybe take another look to see if initdb still leaks anything worth worrying about. regards, tom lane