From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Daniel Gustafsson <daniel@yesql.se>, wliang@stu.xidian.edu.cn,
        pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: Report a potential memory leak in setup_config()
In-reply-to: <3243399.1644978358@sss.pgh.pa.us>
References: <64ee7543.20d.17efb1270ca.Coremail.wliang@stu.xidian.edu.cn>
 <A7070803-5A15-486E-AE04-ECC13CD10038@yesql.se>
 <3052163.1644942806@sss.pgh.pa.us>
 <20220216012953.6d7bzmsblqou3ru4@alap3.anarazel.de>
 <3239746.1644975946@sss.pgh.pa.us>
 <20220216022118.vvijtgd5rl2b6ucv@alap3.anarazel.de>
 <3243399.1644978358@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 15 Feb 2022 21:25:58 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3244452.1644979091.1@sss.pgh.pa.us>
Date: Tue, 15 Feb 2022 21:38:11 -0500
Message-ID: <3244453.1644979091@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3244453.1644979091%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Yeah, I read that.  I think making the backend read these files directly
> makes a ton of sense, so I'm no longer very excited about improving the
> performance or memory consumption of the replace_token stuff.

Actually, wait a second.  I grant your point about postgres.bki, but
a whole lot of the replace_token calls in initdb are messing with
the configuration files, which (a) is something I don't see changing,
and (b) pretty much none of that could be pushed back to build time.
So even though the config files are a lot smaller than postgres.bki,
maybe there's still a point in polishing replace_token a bit.

			regards, tom lane