From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Ian R. Campbell" <ian.campbell@thepathcentral.com>
cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Missing include in float.h
In-reply-to: 
 <CAOC8YUd7H-REg7sqQD-kcUaE2iCMitimcSGhr5nLYRKq3k1zZQ@mail.gmail.com>
References: 
 <CAOC8YUd7H-REg7sqQD-kcUaE2iCMitimcSGhr5nLYRKq3k1zZQ@mail.gmail.com>
Comments: In-reply-to "Ian R. Campbell" <ian.campbell@thepathcentral.com>
	message dated "Sun, 30 Jan 2022 18:32:58 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <324552.1643567920.1@sss.pgh.pa.us>
Date: Sun, 30 Jan 2022 13:38:40 -0500
Message-ID: <324553.1643567920@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/324553.1643567920%40sss.pgh.pa.us>
Precedence: bulk

"Ian R. Campbell" <ian.campbell@thepathcentral.com> writes:
> In PG 14, the source file "float.h" has one include:
> <math.h>

> It is missing "c.h", which contains the definitions for PGDLLIMPORT,
> float4, float8, etc.

This is standard practice in our header files: they assume that
the calling .c file has already included c.h, postgres.h, or
postgres_fe.h, as appropriate.

There are some portability hacks in c.h that don't work if any
other header is included first, so there would be little
value in trying to include it via other methods.

			regards, tom lane