Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iwtIa-00037O-U4 for pgsql-bugs@arkaria.postgresql.org; Wed, 29 Jan 2020 19:46:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iwtIZ-0004gR-Dw for pgsql-bugs@arkaria.postgresql.org; Wed, 29 Jan 2020 19:46:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iwtIZ-0004eb-5n for pgsql-bugs@lists.postgresql.org; Wed, 29 Jan 2020 19:46:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwtIW-00041H-To for pgsql-bugs@lists.postgresql.org; Wed, 29 Jan 2020 19:46:50 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 00TJkjOL032561; Wed, 29 Jan 2020 14:46:45 -0500 From: Tom Lane To: Stephen Frost cc: Alvaro Herrera , Ferdi Smit , Floris Van Nee , "pgsql-bugs@lists.postgresql.org" Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly In-reply-to: References: <20191203202745.GR6962@tamriel.snowman.net> <20200117212624.GA7872@alvherre.pgsql> Comments: In-reply-to Stephen Frost message dated "Wed, 29 Jan 2020 14:07:25 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <32559.1580327205.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 29 Jan 2020 14:46:45 -0500 Message-ID: <32560.1580327205@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Stephen Frost writes: > In particular- should we really be setting default privileges for object= s > that are being created by an extension, at all? The more I think about = it, > the less I like it, particularly when we start to think about the truste= d > extension work that Tom=E2=80=99s doing. > In short, I=E2=80=99m leaning towards the argument that this was a missi= ng check in > the default ACL code to explicitly *not* add default privileges on objec= ts > that are being created by an extension. With such a check, the entire > wouldn=E2=80=99t end up in pg_init_privs and the issue that started this= thread > wouldn=E2=80=99t happen. Hmm. I think we'd still wish pg_upgrade to preserve whatever privileges have been granted on extension objects, but that doesn't necessarily have to happen through pg_init_privs. I've forgotten the details --- would the change you suggest be enough to make upgrade work correctly, or would we need additional hacking? regards, tom lane