From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: dwwoelfel@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19380: Transition table in AFTER INSERT trigger misses rows
 from MERGE when used with INSERT in a CTE
In-reply-to: 
 <CAEZATCX3obg5BP3g36LFDhsZgG9BYPN3qQusz_F-K=-yOoPJCw@mail.gmail.com>
References: <19380-4e293be2b4007248@postgresql.org>
 <CAEZATCVtbX5+qxbHAW=KGQUVv3hJCAC3pKZppy46Gac2t6gAsg@mail.gmail.com>
 <1576968.1768929680@sss.pgh.pa.us> <1698130.1768932056@sss.pgh.pa.us>
 <CAEZATCX3obg5BP3g36LFDhsZgG9BYPN3qQusz_F-K=-yOoPJCw@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Sat, 24 Jan 2026 11:48:41 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3256997.1769270320.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 24 Jan 2026 10:58:40 -0500
Message-ID: <3256998.1769270320@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3256998.1769270320%40sss.pgh.pa.us>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> I've pushed this now. Expecting to have to push updates to
> .abi-compliance-history soon.

crake has reported in [1]:

Leaf changes summary: 2 artifacts changed
Changed leaf types summary: 2 leaf types changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added fun=
ction (2 filtered out)
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added var=
iable

'struct AfterTriggersTableData' changed:
  type size changed from 80 to 64 (in bytes)
  2 data member deletions:
    'Tuplestorestate* old_del_tuplestore', at offset 56 (in bytes)
    'Tuplestorestate* new_ins_tuplestore', at offset 64 (in bytes)
  there are data member changes:
    'TupleTableSlot* storeslot' offset changed from 72 to 56 (in bytes) (b=
y -16 bytes)

'struct TransitionCaptureState' changed:
  type size changed from 24 to 40 (in bytes)
  2 data member insertions:
    'AfterTriggersTableData* tcs_update_private', at offset 24 (in bytes)
    'AfterTriggersTableData* tcs_delete_private', at offset 32 (in bytes)
  there are data member changes:
    name of 'TransitionCaptureState::tcs_private' changed to 'TransitionCa=
ptureState::tcs_insert_private'


I find it unhelpful that it reported the AfterTriggersTableData
change as an ABI change, even though that struct is not globally
accessible.  I wonder if there's some libabigail switches we
should be tweaking to refine that.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dcrake&=
dt=3D2026-01-24%2013%3A06%3A41&stg=3Dabi-compliance-check