From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Masahiko Sawada <sawada.mshk@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Dmitry Koval <d.koval@postgrespro.ru>,
        Dilip Kumar <dilipbalaut@gmail.com>, andrewbille@gmail.com,
        pgsql-bugs@lists.postgresql.org,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable
 transaction causes Assert at the transaction end
In-reply-to: <YzEfR9UUb3gqRjoA@paquier.xyz>
References: 
 <CAD21AoDWHkBBGvvJuLEBqMjiPiYOiVJ6voFBWYbOBsU+-Cot2A@mail.gmail.com>
 <20220628003720.GG19662@telsasoft.com>
 <CAD21AoBz4xZ3uOZS+xYENsYta4PPPkGYPDzzPqqw5GJgrQC7hg@mail.gmail.com>
 <Yrv1nRsfasco768G@paquier.xyz>
 <CAD21AoC8FQqHY8knG7+6-eQe39wjXPtqyki29OAb5OHhq7-p+Q@mail.gmail.com>
 <CAD21AoD6n62NXB5OuYSONYHKNkR=fqvJ5+82y=4Z=-KuFeOV0w@mail.gmail.com>
 <2604497.1664053071@sss.pgh.pa.us> <YzEfR9UUb3gqRjoA@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 26 Sep 2022 12:40:55 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3269449.1664165784.1@sss.pgh.pa.us>
Date: Mon, 26 Sep 2022 00:16:24 -0400
Message-ID: <3269450.1664165784@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3269450.1664165784%40sss.pgh.pa.us>
Precedence: bulk

[ hit send too soon ... ]

Michael Paquier <michael@paquier.xyz> writes:
> On Sat, Sep 24, 2022 at 04:57:51PM -0400, Tom Lane wrote:
>> 0002 seems quite invasive and hard to review compared to what it
>> accomplishes.

> 0002 is not that confusing to me: the units are moved to be first and
> to use the first flag bytes, while the more conceptual flags are moved
> to be always after.

Yeah, but why?  I see no good reason why those fields need to be first.

> I would have reorganized a bit more the
> description flags, TBH.

Looking at it closer, I agree that GUC_EXPLAIN and GUC_RUNTIME_COMPUTED
should be moved to be with the other non-units flags.  But I don't
see why we need to re-order the entries more than that.  I'm concerned
for one thing that the order of the entries in this list stay comparable
to the order in which the flags are dealt with in other code, such as
pg_settings_get_flags or the guc_tables.c entries.

			regards, tom lane