From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
cc: Laurenz Albe <laurenz.albe@cybertec.at>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on
 composing an error message when adding a type to an extension being dropped)
In-reply-to: 
 <CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
References: <17098-b960f3616c861f83@postgresql.org>
 <2468663.1626017338@sss.pgh.pa.us> <2984422.1626110456@sss.pgh.pa.us>
 <dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
 <3227956.1626186568@sss.pgh.pa.us>
 <CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
Comments: In-reply-to Ranier Vilela <ranier.vf@gmail.com>
	message dated "Tue, 13 Jul 2021 15:04:19 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3280447.1626200778.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 13 Jul 2021 14:26:18 -0400
Message-ID: <3280448.1626200778@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3280448.1626200778%40sss.pgh.pa.us>
Precedence: bulk

Ranier Vilela <ranier.vf@gmail.com> writes:
> Em ter., 13 de jul. de 2021 =C3=A0s 11:29, Tom Lane <tgl@sss.pgh.pa.us> =
escreveu:
>> I think you're missing my main point, which is that it seems certain th=
at
>> there are corner cases that do this *now*.  I'm proposing that we redef=
ine
>> this as not being a crash case, full stop.

> I agree with Laurenz Albe, that on Debug builds, *printf with NULL, must
> crash.

Did you see my followup?  The vast majority of live systems do not do
that, so we are accomplishing nothing of value by insisting it's a
crash-worthy bug.

I flat out don't agree that "crash on debug builds but it's okay on
production" is a useful way to define this.  I spend way too much
time already on bug reports that only manifest with asserts enabled.

			regards, tom lane