From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Masahiko Sawada <sawada.mshk@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Dmitry Koval <d.koval@postgrespro.ru>,
        Dilip Kumar <dilipbalaut@gmail.com>, andrewbille@gmail.com,
        pgsql-bugs@lists.postgresql.org,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable
 transaction causes Assert at the transaction end
In-reply-to: <YzF286gtXNEluOKe@paquier.xyz>
References: 
 <CAD21AoDWHkBBGvvJuLEBqMjiPiYOiVJ6voFBWYbOBsU+-Cot2A@mail.gmail.com>
 <20220628003720.GG19662@telsasoft.com>
 <CAD21AoBz4xZ3uOZS+xYENsYta4PPPkGYPDzzPqqw5GJgrQC7hg@mail.gmail.com>
 <Yrv1nRsfasco768G@paquier.xyz>
 <CAD21AoC8FQqHY8knG7+6-eQe39wjXPtqyki29OAb5OHhq7-p+Q@mail.gmail.com>
 <CAD21AoD6n62NXB5OuYSONYHKNkR=fqvJ5+82y=4Z=-KuFeOV0w@mail.gmail.com>
 <2604497.1664053071@sss.pgh.pa.us> <YzEfR9UUb3gqRjoA@paquier.xyz>
 <3269450.1664165784@sss.pgh.pa.us> <YzF286gtXNEluOKe@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 26 Sep 2022 18:54:59 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3334937.1664189987.1@sss.pgh.pa.us>
Date: Mon, 26 Sep 2022 06:59:47 -0400
Message-ID: <3334938.1664189987@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3334938.1664189987%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Sep 26, 2022 at 12:16:24AM -0400, Tom Lane wrote:
>> Yeah, but why?  I see no good reason why those fields need to be first.

> My reasoning on these ones is that we are most likely going to add
> more description flags in the future than new unit types.  Perhaps I
> am wrong.

Sure, but we could easily leave unused bits there.  Aligning the
units subfields on byte boundaries might result in slightly better
machine code, anyway.

			regards, tom lane