Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1seMZO-006LKN-H5
	for pgsql-bugs@arkaria.postgresql.org; Wed, 14 Aug 2024 22:34:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1seMZM-00DCqN-Ry
	for pgsql-bugs@arkaria.postgresql.org; Wed, 14 Aug 2024 22:34:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1seMZM-00DCqF-JF
	for pgsql-bugs@lists.postgresql.org; Wed, 14 Aug 2024 22:34:16 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1seMZK-004svD-66
	for pgsql-bugs@lists.postgresql.org; Wed, 14 Aug 2024 22:34:16 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 47EMYAlD335475;
	Wed, 14 Aug 2024 18:34:10 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Peter Smith <smithpb2250@gmail.com>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on
 attempt to use system column
In-reply-to: 
 <CAApHDvpw2r1XS4LaN90dkfaSOsWuyj_HDevV6avtn+EMe1fUxQ@mail.gmail.com>
References: <18558-411bc81b03592125@postgresql.org>
 <CAHut+Pt88zYZfWLj6jnMrQw1CwxeYtp1TmF7vrZ2F6Cyvb=5yQ@mail.gmail.com>
 <2455740.1722219823@sss.pgh.pa.us>
 <CAHut+PtDehGqTDo24+jYQ_eo33geJ_4X+ObkFpw18SU_a6U6pw@mail.gmail.com>
 <2460423.1722222076@sss.pgh.pa.us>
 <CAHut+PtUPP0gC2HqKT8_ouZWeyxJMzeLOYtWo=UsyN29NY8dew@mail.gmail.com>
 <CAApHDvo2i1j_iCFcURx5q7jYe70qk4Ca7J+8Dt9_jSMOdooAOA@mail.gmail.com>
 <CAHut+Ptp6Ztk-Dst_WDmQpAw+Zy9EbP_8QSNk5NkDEjP=8xK-A@mail.gmail.com>
 <CAApHDvp+fowDHnnz6JAGqEsfh9L5KGYBJ+j9hobxcOHKSjmwmw@mail.gmail.com>
 <CAHut+PvbZvE5FOgNAgqW0E3h0mnA4sLtkO+J_1o-o5DXcrCOQw@mail.gmail.com>
 <CAApHDvp=K+f8jH=WJ_-epXFW4FMnocY+-BrYQYbEBpLd02-H2w@mail.gmail.com>
 <CAHut+Pt0A3-1nqb0WaEsaQU3mtdw_gSGCFDj2CbR=Z_b3BHPsA@mail.gmail.com>
 <CAApHDvpw2r1XS4LaN90dkfaSOsWuyj_HDevV6avtn+EMe1fUxQ@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Thu, 15 Aug 2024 10:28:43 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <335473.1723674850.1@sss.pgh.pa.us>
Date: Wed, 14 Aug 2024 18:34:10 -0400
Message-ID: <335474.1723674850@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/335474.1723674850%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> As for this being backpatched or not. For me, about 51% of me thinks
> this is fine for a master-only fix.
> Does anyone else have any thoughts about back-patching the fix?

It does seem mostly cosmetic, since we're just replacing one error
message with a better one.

			regards, tom lane