From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Jelte Fennema <postgres@jeltef.nl>, Michael Paquier <michael@paquier.xyz>,
        duspensky@ya.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server
 with SSL encryption
In-reply-to: <20210316180109.ko6vqm7n4iovzryf@alap3.anarazel.de>
References: <16160-18367e56e9a28264@postgresql.org>
 <20191213063915.GE1942@paquier.xyz> <20191214092456.GB70616@paquier.xyz>
 <CAGECzQTucR20CLwb6mw_JLdVST8GqYNqYr1OmAnNS2Byg8r+dg@mail.gmail.com>
 <3255514.1615912277@sss.pgh.pa.us>
 <20210316180109.ko6vqm7n4iovzryf@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 16 Mar 2021 11:01:09 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3376867.1615917814.1@sss.pgh.pa.us>
Date: Tue, 16 Mar 2021 14:03:34 -0400
Message-ID: <3376868.1615917814@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3376868.1615917814%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2021-03-16 12:31:17 -0400, Tom Lane wrote:
>> I'm wondering about that because I see some other stuff in be_tls_init()
>> that looks like it might get leaked, notably the root_cert_list read
>> from the ssl_ca_file.

> Given that we're careful to destroy the "temporary" ssl context in case
> of error, perhaps the best way to deal with root_cert_list being freed
> in case of error would be to assign it to the context as soon as its
> loaded?

Yeah, I came to the same conclusion downthread.  I'll go see about
making that happen.

			regards, tom lane