From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Jorge Gustavo Rocha <jgr@geomaster.pt>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf
 using Python psycopg2
In-reply-to: <20190621004233.GA1626@paquier.xyz>
References: <82491.1559409563@sss.pgh.pa.us>
 <e12a23c6-5e00-3fa6-6179-681336130361@geomaster.pt>
 <1473.1560866085@sss.pgh.pa.us>
 <fcb5c34c-cf5f-6dc9-c68e-6b297f073b79@geomaster.pt>
 <CA+mi_8aBnLKypX2Ttksg8JEhApBo=JpF6P_STQGp-FOvDpn6Yw@mail.gmail.com>
 <81d9d421-6947-7111-a1dc-cfd99cd3ae53@geomaster.pt>
 <23215.1560977098@sss.pgh.pa.us> <20190620031218.GC2660@paquier.xyz>
 <20190620070319.GH2660@paquier.xyz>
 <0a9fcd30-5ae2-7e5f-ac1d-60d14a2ebb63@geomaster.pt>
 <20190621004233.GA1626@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 21 Jun 2019 09:42:33 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3382.1561078113.1@sss.pgh.pa.us>
Date: Thu, 20 Jun 2019 20:48:33 -0400
Message-ID: <3383.1561078113@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Thanks for testing.  It seems to me that the current behavior is just
> annoying, so there is a good argument for back-patching.  Now it is
> true that we have had few complaints on the matter over the years, and
> usually in those cases we bother only about HEAD.  I would still do a
> back-patch in this case.  Any Thoughts from others?

I'm still of the opinion that

(1) it's very weird that this code allows for leading space on a line
but not trailing space;

(2) we need to look for other places where we have the same issue.

Possibly libpq is the only chunk of our code that's at serious risk,
since we don't change the default binary mode in the backend.  But
even if you assume that that's true, this isn't the only config file
that libpq examines.

			regards, tom lane