From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Dean Rasheed <dean.a.rasheed@gmail.com>, dwwoelfel@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19380: Transition table in AFTER INSERT trigger misses rows
 from MERGE when used with INSERT in a CTE
In-reply-to: <hvus56twlvqnucatfamtodwwt4kaxfmorksxc2yk6su6p2teph@xjy4r6uvsaqd>
References: <19380-4e293be2b4007248@postgresql.org>
 <CAEZATCVtbX5+qxbHAW=KGQUVv3hJCAC3pKZppy46Gac2t6gAsg@mail.gmail.com>
 <1576968.1768929680@sss.pgh.pa.us> <1698130.1768932056@sss.pgh.pa.us>
 <CAEZATCX3obg5BP3g36LFDhsZgG9BYPN3qQusz_F-K=-yOoPJCw@mail.gmail.com>
 <3256998.1769270320@sss.pgh.pa.us>
 <hvus56twlvqnucatfamtodwwt4kaxfmorksxc2yk6su6p2teph@xjy4r6uvsaqd>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 24 Jan 2026 12:03:49 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3405727.1769275655.1@sss.pgh.pa.us>
Date: Sat, 24 Jan 2026 12:27:35 -0500
Message-ID: <3405728.1769275655@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3405728.1769275655%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2026-01-24 10:58:40 -0500, Tom Lane wrote:
>> I find it unhelpful that it reported the AfterTriggersTableData
>> change as an ABI change, even though that struct is not globally
>> accessible.  I wonder if there's some libabigail switches we
>> should be tweaking to refine that.

> Specifying --headers-dir ... during abidw seems to do the trick.

Yeah, I was just experimenting with that.  It's pretty unclear
from the abigail docs whether you have to name all the header
directories explicitly or it's enough to point at the top one ...
but experimentation says the top one is enough.

I'll send Andrew a patch.

			regards, tom lane