Message-ID: <3422d282fd45e460b4ce1bd0745523ba63bd3848.camel@cybertec.at>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Nisha Moond	
 <nisha.moond412@gmail.com>, Gunnar Morling <gunnar.morling@googlemail.com>,
 	pgsql-bugs@lists.postgresql.org
Date: Sat, 05 Jul 2025 07:35:38 +0200
In-Reply-To: 
 <CAA4eK1Lp+ZY2Mr3jtspF_oKDUx7241h_Ke7g5g+D-XHFA7xC+g@mail.gmail.com>
References: 
	<CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
	 <CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
	 <30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
	 <b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
	 <686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
	 <CAA4eK1Lp+ZY2Mr3jtspF_oKDUx7241h_Ke7g5g+D-XHFA7xC+g@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-qhZ3RC06ukE82+DgcBUV"
User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/3422d282fd45e460b4ce1bd0745523ba63bd3848.camel%40cybertec.at>
Precedence: bulk

--=-qhZ3RC06ukE82+DgcBUV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2025-07-05 at 09:52 +0530, Amit Kapila wrote:
> On Fri, Jul 4, 2025 at 9:37=E2=80=AFPM Laurenz Albe <laurenz.albe@cyberte=
c.at> wrote:
> > What exactly does it mean for a replication slot to idle?
> >=20
> > - Does it mean that the standby is not connected?
>=20
> It means the above. The slot is used for purposes other than the
> standby as well, so we can't mention something only specific to the
> standby.
>=20
> > I think we could do better here.
>=20
> Sure, feel free to propose what you think makes it better.

Done in the attached patch.

> We expect the value of this variable to be in hours or, in some cases,
> days. Specifying in seconds would be inconvenient for users.

I don't buy that argument.  Specifying shared_buffers in 8kB blocks
would be quite inconvenient to most users, but I don't remember any
complaints about it.  One of the nice things about the Grand Unified
Configuration is that you can use units different from the default.

On the other hand, if the behavior is clearly documented, as I have
tried to do with my patch, it should be fine.  So I'll rest my case if
you apply my patch.

Yours,
Laurenz Albe

--=-qhZ3RC06ukE82+DgcBUV
Content-Disposition: attachment;
	filename="v1-0001-Improve-doc-for-idle_replication_slot_timeout.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
	name="v1-0001-Improve-doc-for-idle_replication_slot_timeout.patch";
	charset="UTF-8"

RnJvbSBlNDlhZDAwMzRlZTU1NTc3YzhlODgxYjliYTQyMzIwMzFiYTYzOWUyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogU2F0LCA1IEp1bCAyMDI1IDA3OjI3OjEwICswMjAwClN1YmplY3Q6IFtQQVRDSCB2
MV0gSW1wcm92ZSBkb2MgZm9yIGlkbGVfcmVwbGljYXRpb25fc2xvdF90aW1lb3V0CgpEZWZpbmUg
d2hhdCBleGFjdGx5IGlzIG1lYW50IGJ5ICJpZGxlIiBoZXJlLiAgQWxzbywgZW1waGFzaXplIHRo
YXQKdGhlIHZhbHVlIGlzIHJvdW5kZWQgdG8gbWludXRlcywgc2luY2UgdGhhdCBjYXVzZWQgc29t
ZSBzdXJwcmlzZQpkdXJpbmcgYmV0YSB0ZXN0aW5nLgoKQXV0aG9yOiBMYXVyZW56IEFsYmUgPGxh
dXJlbnouYWxiZUBjeWJlcnRlYy5hdD4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9D
QURHSmFYXzAlMkJGVGd1V3BOU3BnVldZUVBfN01ob08wRDglM0RjcDRYb3pTUWdhWjQwT2R3JTQw
bWFpbC5nbWFpbC5jb20KLS0tCiBkb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgfCAxNCArKysrKysr
Ky0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgYi9kb2Mvc3JjL3NnbWwvY29u
ZmlnLnNnbWwKaW5kZXggNTlhMDg3NDUyOGEuLjJiNGY5ZjM0Y2Y0IDEwMDY0NAotLS0gYS9kb2Mv
c3JjL3NnbWwvY29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sCkBAIC00
NjE4LDEyICs0NjE4LDE0IEBAIHJlc3RvcmVfY29tbWFuZCA9ICdjb3B5ICJDOlxcc2VydmVyXFxh
cmNoaXZlZGlyXFwlZiIgIiVwIicgICMgV2luZG93cwogICAgICAgPC90ZXJtPgogICAgICAgPGxp
c3RpdGVtPgogICAgICAgIDxwYXJhPgotICAgICAgICBJbnZhbGlkYXRlIHJlcGxpY2F0aW9uIHNs
b3RzIHRoYXQgaGF2ZSByZW1haW5lZCBpZGxlIGxvbmdlciB0aGFuIHRoaXMKLSAgICAgICAgZHVy
YXRpb24uIElmIHRoaXMgdmFsdWUgaXMgc3BlY2lmaWVkIHdpdGhvdXQgdW5pdHMsIGl0IGlzIHRh
a2VuIGFzCi0gICAgICAgIG1pbnV0ZXMuIEEgdmFsdWUgb2YgemVybyAodGhlIGRlZmF1bHQpIGRp
c2FibGVzIHRoZSBpZGxlIHRpbWVvdXQKLSAgICAgICAgaW52YWxpZGF0aW9uIG1lY2hhbmlzbS4g
VGhpcyBwYXJhbWV0ZXIgY2FuIG9ubHkgYmUgc2V0IGluIHRoZQotICAgICAgICA8ZmlsZW5hbWU+
cG9zdGdyZXNxbC5jb25mPC9maWxlbmFtZT4gZmlsZSBvciBvbiB0aGUgc2VydmVyIGNvbW1hbmQK
LSAgICAgICAgbGluZS4KKyAgICAgICAgSW52YWxpZGF0ZSByZXBsaWNhdGlvbiBzbG90cyB0aGF0
IGhhdmUgYmVlbiBpbmFjdGl2ZSAobm90IHVzZWQgYnkgYQorICAgICAgICA8bGluayBsaW5rZW5k
PSJwcm90b2NvbC1yZXBsaWNhdGlvbiI+cmVwbGljYXRpb24gY29ubmVjdGlvbjwvbGluaz4pCisg
ICAgICAgIGZvciBsb25nZXIgdGhhbiB0aGlzIGR1cmF0aW9uLiBJZiB0aGUgdmFsdWUgaXMgc3Bl
Y2lmaWVkIHdpdGhvdXQKKyAgICAgICAgdW5pdHMsIGl0IGlzIHRha2VuIGFzIG1pbnV0ZXMuIFZh
bHVlcyBzcGVjaWZpZWQgaW4gdW5pdHMgc21hbGxlciB0aGFuCisgICAgICAgIGEgbWludXRlIGFy
ZSByb3VuZGVkIHRvIHRoZSBuZWFyZXN0IG1pbnV0ZS4gQSB2YWx1ZSBvZiB6ZXJvICh0aGUKKyAg
ICAgICAgZGVmYXVsdCkgZGlzYWJsZXMgdGhlIGlkbGUgdGltZW91dCBpbnZhbGlkYXRpb24gbWVj
aGFuaXNtLiBUaGlzCisgICAgICAgIHBhcmFtZXRlciBjYW4gb25seSBiZSBzZXQgaW4gdGhlIDxm
aWxlbmFtZT5wb3N0Z3Jlc3FsLmNvbmY8L2ZpbGVuYW1lPgorICAgICAgICBmaWxlIG9yIG9uIHRo
ZSBzZXJ2ZXIgY29tbWFuZCBsaW5lLgogICAgICAgIDwvcGFyYT4KIAogICAgICAgIDxwYXJhPgot
LSAKMi41MC4wCgo=


--=-qhZ3RC06ukE82+DgcBUV--