Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xN7JA-00000002NdY-3rti for pgsql-bugs@arkaria.postgresql.org; Sat, 31 Oct 2026 11:31:37 +0000 Received: from localhost ([127.0.0.1]:37292 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xN7J9-0000000ETDE-1Mjk for pgsql-bugs@arkaria.postgresql.org; Sat, 31 Oct 2026 11:31:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:52336) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xN7J8-0000000ETD0-3PzH for pgsql-bugs@lists.postgresql.org; Sat, 31 Oct 2026 11:31:34 +0000 Received: from mail-wm2-x0b.google.com ([2a00:1450:4864:31::b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xN7J7-00000001qea-0hFr for pgsql-bugs@lists.postgresql.org; Sat, 31 Oct 2026 11:31:33 +0000 Received: by mail-wm2-x0b.google.com with SMTP id 5b1f17b1804b1-4a1d25d7d5dso6015855e9.1 for ; Sat, 31 Oct 2026 04:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793446291; x=1794051091; darn=lists.postgresql.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=4C+mleogHoVDzLUdRtOsACf/Up/Z/tw9OFzMVnAoh5Q=; b=RQ8JcqIK9zjZjHlqjneemY5SZcvkgt9GOmxbMUSa9UoNpBdKwcrNaUAKbS+SUCczsf CrkgfkWH5vq0ofr79p0iy/1IcFBmLxj2yTry4IFilT4zFyCyAU392NcsTHD4npCbxANR EpY34pZgIg2XNzsj1imCX001fOwEcP1Kx0xXB4NLtkcJR42tJKS+OKBUmUKoDWSD1nb6 w2jftyVg/jK7pIZNm+RnPOJ/ed7picpLWmleRFOTDOxVdTqELJItZffXawim4wGsQpJo etJ0Jtn/Yxi5lUinSWZG8yJNwAG3QPSsSFKEQkgzCwvMB19GDKd5kJDjUbk69baquLNF Gp0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793446291; x=1794051091; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4C+mleogHoVDzLUdRtOsACf/Up/Z/tw9OFzMVnAoh5Q=; b=TmHfdaF36BpcXd8bP5N2FIyNHwmiEexN2bj5kdlpfUki6rM47zQoPi1a7SAB9fSaW+ 1rT6be2X7Xa0Tycmjj4wDA0wRIuDa9rMZZi7tnpzjRjvlrOwmtwsnu31qrQDMlb4LEjS 1AtB99ctj5UXggTyU3hozpDP1VmyEpjEoj8LBdrmgjKzVQC0D++LD8GzeQxnvaI8CLe/ 2OBS2xtOmY9U5is1eTeaQxly0JE1xtixAT153MceYF3HBveKh0TA1pDNn9nPsYLCmKgu EE0O/qSgMjxGT1vS0JzhWBCUObbMO4JEpFoGCIfNeuc2FVPww+u/VzcIrAh4wIU9EN8D a9zA== X-Forwarded-Encrypted: i=1; AKwUvBy6StAFmyq8vDj/4w4TBLP8fOlzJglF6FxApynFx3GIxY3+iP6nwbRFtI4THpC4niK6pB+xd1IgADOI@lists.postgresql.org X-Gm-Message-State: AFq9FYKz/Rt1hDxHZUjWEfEbesfTjLGEfe7NeNWiHI3XQJvAdbU0PqCx 0LFrlCfsI8QAzPT+BeHDDhbqIajw5YMY1Yeyp/WkgO5ODIURlIzNEC7R X-Gm-Gg: AYBFou2qmRmb2KH/+CRyXOTs1TOAOEIE/qmmC5ix2k+ClzVTWe1kY/lCmtfbnJc6edJ vULoqcUY8oq5HOYEB12vwFnjpZMjLPmcCGOYVspc1rJYdiNujOorJB4JyenYIhq3kTHor0/+1kK hKdblgKUvJMr5gTmanwwjH3mQvrRtbzGwJtvwPQPxqoupD5d9acS0pgWqK3R/xvnkk48OSEecwL 6+z4eRL7mpI62i6XfWy9oJLiXASfNzpq+LVrb6MUObLMQoF6Abi/ORIJhRfq8O6F9hJHaqI+7Wm 9Eqsa05djH1Iuu+/WNYN+SfxKtr6pBo+K5+kfDageVOEUQPjcafQfg9TNNzrnBk0ApmvCRDYI3S VS7D8ICHZJfSPIUGZso1eUsgkg1wHM39S9PS5WFwXn/6fniwgzJlYJQcepyaxuXTTkrB7PSSSMa j86PfhfmRVDkrD8tFrilhc0jIg433T/0XUAr/MPUblQkPviuaGyxoWuEe0BBeCWGfI7kf7J/aOd wu1nn4Rw+MlQ0PJS+WXZzUcIQiIGShbkJPiWjLeyTn/QutoAFEmOJ2oPPtLAw4TZuvLKu1UWsDm +9QxMBSzY9nlB8RA6sheaDFkQIXx6DkthqFq3MfT9oVnWaNeyT+Nrx9gOvRkezUOWl2I0aKzugg ghhHc5VoRFC8HrdZVHxjl4ZJ1769F1BbT5lR7w+zq1bzf6UhZRniFfH+LCgZV26gvzpmxf+2R9x NyrSmdTg== X-Received: by 2002:a05:6000:2486:b0:48d:ff81:5201 with SMTP id ffacd0b85a97d-48e6e4f44f2mr11441614f8f.41.1793446290651; Sat, 31 Oct 2026 04:31:30 -0700 (PDT) Received: from [17.235.221.176] ([17.235.221.176]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71a4d3cesm8970798f8f.7.2026.10.31.04.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Oct 2026 04:31:30 -0700 (PDT) Message-ID: <34348588-9b17-4b9b-a069-11f106cdc32a@gmail.com> Date: Sat, 31 Oct 2026 19:31:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value To: Kirill Reshke , "Hayato Kuroda (Fujitsu)" Cc: "brar@gmx.de" , "pgsql-bugs@lists.postgresql.org" References: <19795-6d7d506133b7f062@postgresql.org> From: Zhijie Hou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Wed, Oct 28, 2026 at 01:36 AM Kirill Reshke wrote: > Looks like a real issue. I reviewed a patch, I think this is a natural > follow-up for [0]. the CREATE_REPLICATION_SLOT/ALTER_REPLICATION_SLOT > option parser only uses defGetString/defGetBoolean - pgoutput is the > only crasher. > > Also, should we reject option like > > ereport(ERROR, > (errcode(ERRCODE_INVALID_PARAMETER_VALUE), > errmsg("option \"%s\" requires a value", > "publication_names"))); > > > instead of a generic error message from defGetString? I think a special message is unnecessary here, especially since we don't do that in other replication parsing code, so I've kept the current version. -- Best Regards, Zhijie Hou