Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1wvbuM-001OY2-1b
	for pgsql-bugs@arkaria.postgresql.org;
	Sun, 16 Aug 2026 14:32:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1wvbuK-006J86-1P
	for pgsql-bugs@arkaria.postgresql.org;
	Sun, 16 Aug 2026 14:32:17 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wvbuK-006J7y-0b
	for pgsql-bugs@lists.postgresql.org;
	Sun, 16 Aug 2026 14:32:17 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wvbuJ-00000000uUP-2q0J
	for pgsql-bugs@lists.postgresql.org;
	Sun, 16 Aug 2026 14:32:16 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 67GEWEAZ343803;
	Sun, 16 Aug 2026 10:32:14 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andrey Rachitskiy <pl0h0yp1@gmail.com>, ilia.kashintsev@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19612: SEGV in ParseConfigFp() in guc-file.l
In-reply-to: <aoFTGfKWOFxVZojJ@paquier.xyz>
References: <19612-24ccb4fc6da7786f@postgresql.org>
 <CAB8bMivnXcb7RRd=EKdY_nBOqR=6iJPwZx1oEGz+ayfqzj9HVQ@mail.gmail.com>
 <an1__bbJ4MNfy9Lp@paquier.xyz>
 <CAB8bMitdZN9RX+Yf8j1A2sBsrATNN39FX7biUi1T4G7V2XLHag@mail.gmail.com>
 <aoFTGfKWOFxVZojJ@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sun, 16 Aug 2026 15:05:13 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <343801.1786890734.1@sss.pgh.pa.us>
Date: Sun, 16 Aug 2026 10:32:14 -0400
Message-ID: <343802.1786890734@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/343802.1786890734%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> It seems to me that we should also have a `goto cleanup` if
> yylex_init() fails, also pointing at d663f150b5ed that has switched
> the scanner to be reentrant where yylex_init() has been added.

Yeah.  The other thing not being covered here is the possibility
that yy_create_buffer fails and returns NULL.

			regards, tom lane