From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: David Rowley <dgrowleyml@gmail.com>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
In-reply-to: <ZX1rmhppwgaczYQ7@paquier.xyz>
References: <18240-c5da758d7dc1ecf0@postgresql.org>
 <ZXbi3xo7QhQIe1YN@paquier.xyz> <2171714.1702307153@sss.pgh.pa.us>
 <ZXgh74Ykj3iWvXKr@paquier.xyz>
 <CAApHDvrBLa=gQ0tCg8727RaZXWDg1sDvFJ2+-DVy5SC=NSSKkg@mail.gmail.com>
 <2433182.1702391878@sss.pgh.pa.us> <ZX1rmhppwgaczYQ7@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 16 Dec 2023 10:19:22 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3453262.1702739958.1@sss.pgh.pa.us>
Date: Sat, 16 Dec 2023 10:19:18 -0500
Message-ID: <3453263.1702739958@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3453263.1702739958%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Dec 12, 2023 at 09:37:58AM -0500, Tom Lane wrote:
>> ... Perhaps we could allow extension
>> modules to use binary_upgrade_set_next_pg_type_oid, and then somehow
>> reserve the money and _money OIDs forever?

> Now, I am not sure that we're making users a favor in keeping around a
> data type that's kind of obsolete these days, particularly when all of
> them basically require handling of fractional cents when doing serious
> calculations.  That's a trap in disguise, even if tying data to a
> locale for the unit sounds appealing for some applications.

Yeah, I wouldn't propose this if money were the only type we were
thinking of getting rid of; likely not worth the trouble.  But I've
got one eye on the geometric types as well --- I think it would be
great all around if we could kick those out of the core distribution
and let them be maintained independently.  But I fear we can't do that
without some method whereby pg_upgrade is still possible across the
change.

			regards, tom lane