Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS1pH-0007uJ-0t for pgsql-bugs@arkaria.postgresql.org; Thu, 01 Apr 2021 18:13:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1pF-0001Y7-Oz for pgsql-bugs@arkaria.postgresql.org; Thu, 01 Apr 2021 18:13:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS1pF-0001W4-Il for pgsql-bugs@lists.postgresql.org; Thu, 01 Apr 2021 18:13:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS1pC-0008KY-RV for pgsql-bugs@lists.postgresql.org; Thu, 01 Apr 2021 18:13:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 131IDcFT3457934; Thu, 1 Apr 2021 14:13:38 -0400 From: Tom Lane To: Justin Pryzby cc: Sergey KOPOSOV , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16951: pg_restore segfaults on custom format piped from a different version of PG In-reply-to: <20210401175634.GI4431@telsasoft.com> References: <16951-a4dd68cf0de23048@postgresql.org> <3331060.1617226031@sss.pgh.pa.us> <5d848bddbb3b6421af5a742e36ede542e719c492.camel@ed.ac.uk> <3338139.1617230824@sss.pgh.pa.us> <51cec7215378e9beccb9b58831f6e0a2be30bd06.camel@ed.ac.uk> <3413025.1617291573@sss.pgh.pa.us> <20210401175634.GI4431@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Thu, 01 Apr 2021 12:56:34 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3457932.1617300818.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 01 Apr 2021 14:13:38 -0400 Message-ID: <3457933.1617300818@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Thu, Apr 01, 2021 at 11:39:33AM -0400, Tom Lane wrote: >> Will fix, thanks for the report! > Yes, thank you both. I've run into this recently but for some reason I = thought > it was fixed. It probably also explains this one from 2014. > https://www.postgresql.org/message-id/20141206061151.GA725@telsasoft.com Yeah, this does look suspiciously like it explains some past reports that we failed to reproduce, likely because it didn't occur to us that reading the file from a non-seekable source would make a difference. Thanks to Sergey for beating me over the head till I didn't dismiss it anymore ;-) regards, tom lane